Optimize BlockInventoryMessage#56
Merged
Dream-Master merged 9 commits intomasterfrom Apr 26, 2026
Merged
Conversation
Dream-Master
added
the
🚧 Testing on Zeta
Luca-Guettinger
left a comment
Luca-Guettinger
left a comment
There was a problem hiding this comment.
Good direction, the O(n) merge is a clear improvement over the nested loop and the null safety fixes are needed. A few rough edges remain (the ones Nikolay flagged plus the loop condition and map type choice below).
Luca-Guettinger
previously approved these changes
Apr 26, 2026
|
@ABKQPO okay so it seems that Object2LongOpenCustomHashMap is not avaliable at runtime, you probably need to revert that change then. |
Member
|
GTNHLib needs to be added as dependency |
Luca-Guettinger
approved these changes
Apr 26, 2026
Dream-Master
removed
the
🚧 Testing on Zeta
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor the Handler part, add missing null checks, and optimize the item merging from O(n²) to O(n) to reduce unnecessary performance overhead