Skip to content

feat(witchery): add witchery vampire support for sleep percentage.#268

Open
hinyb wants to merge 5 commits intoGTNewHorizons:masterfrom
hinyb:master
Open

feat(witchery): add witchery vampire support for sleep percentage.#268
hinyb wants to merge 5 commits intoGTNewHorizons:masterfrom
hinyb:master

Conversation

@hinyb
Copy link
Copy Markdown

@hinyb hinyb commented Mar 17, 2026

@UltraProdigy UltraProdigy requested a review from Alexdoru March 21, 2026 23:58
Copy link
Copy Markdown
Member

@Lyfts Lyfts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be much more maintainable if you worked mod support into the already existing class for sleep percentage https://github.com/GTNewHorizons/ServerUtilities/blob/master/src/mixins/java/serverutils/mixins/early/minecraft/MixinWorldServer_SleepPercentage when witchery is loaded.

Duplicating all of the code for the same feature into a separate class only complicates future changes.

@hinyb
Copy link
Copy Markdown
Author

hinyb commented May 2, 2026

This would be much more maintainable if you worked mod support into the already existing class for sleep percentage https://github.com/GTNewHorizons/ServerUtilities/blob/master/src/mixins/java/serverutils/mixins/early/minecraft/MixinWorldServer_SleepPercentage when witchery is loaded.

Duplicating all of the code for the same feature into a separate class only complicates future changes.

I originally wanted to use static dispatch for some reason, but you are right, it's unnecessary.
Finished, thanks for the feedback.

@Dream-Master Dream-Master requested a review from Lyfts May 2, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Morpheus Overwrites the Behavior of a Vampire Sleeping in a Coffin (On a Multiplayer Server)

3 participants