Skip to content

fix: Prevent scientific notation in row validation for Db2 REAL/DOUBLE columns#1723

Merged
nj1973 merged 4 commits intodevelopfrom
1722-db2-real-scientific-notation
Apr 10, 2026
Merged

fix: Prevent scientific notation in row validation for Db2 REAL/DOUBLE columns#1723
nj1973 merged 4 commits intodevelopfrom
1722-db2-real-scientific-notation

Conversation

@nj1973
Copy link
Copy Markdown
Collaborator

@nj1973 nj1973 commented Apr 7, 2026

Description of changes

This PR prevents scientific notation in row validation for Db2 REAL/DOUBLE columns. To do this I changed cast(... to varchar) to to_char(...). In my tests, with this change in place, I did not see scientific notation used.

I cannot add col_float32/64 to tests though due to general differences in string conversion output. I added an internal doc capturing that for future reference.

Issues to be closed

Closes #1722

Checklist

  • I have followed the CONTRIBUTING Guide.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated any relevant documentation to reflect my changes, if applicable
  • I have added unit and/or integration tests relevant to my change as needed
  • I have already checked locally that all unit tests and linting are passing (use the tests/local_check.sh script)
  • I have manually executed end-to-end testing (E2E) with the affected databases/engines

@nj1973 nj1973 linked an issue Apr 7, 2026 that may be closed by this pull request
@nj1973 nj1973 marked this pull request as ready for review April 8, 2026 07:47
@nj1973
Copy link
Copy Markdown
Collaborator Author

nj1973 commented Apr 8, 2026

/gcbrun

Copy link
Copy Markdown
Collaborator

@sundar-mudupalli-work sundar-mudupalli-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@nj1973
Copy link
Copy Markdown
Collaborator Author

nj1973 commented Apr 10, 2026

/gcbrun

@nj1973 nj1973 merged commit e67dccf into develop Apr 10, 2026
6 checks passed
@nj1973 nj1973 deleted the 1722-db2-real-scientific-notation branch April 10, 2026 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Db2 REAL and DOUBLE row validation output scientific notation

2 participants