Skip to content

fix: custom query row validation on Db2 loses precision and scale#1727

Merged
nj1973 merged 1 commit intodevelopfrom
1706-custom-query-db2-precision-and-scale
Apr 9, 2026
Merged

fix: custom query row validation on Db2 loses precision and scale#1727
nj1973 merged 1 commit intodevelopfrom
1706-custom-query-db2-precision-and-scale

Conversation

@nj1973
Copy link
Copy Markdown
Collaborator

@nj1973 nj1973 commented Apr 8, 2026

Description of changes

Fixes an issue where custom query row validation on Db2 loses decimal precision and scale because it was ignoring cursor.description values.

Updated _get_type() to receive the entire column tuple, rather than just the type string, and extracted precision and scale. This mimics how PostgreSQL and Oracle backends extract type sizes.

Issues to be closed

Closes #1706

Checklist

  • I have followed the CONTRIBUTING Guide.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated any relevant documentation to reflect my changes, if applicable
  • I have added unit and/or integration tests relevant to my change as needed
  • I have already checked locally that all unit tests and linting are passing (use the tests/local_check.sh script)
  • I have manually executed end-to-end testing (E2E) with the affected databases/engines

@nj1973 nj1973 linked an issue Apr 8, 2026 that may be closed by this pull request
@nj1973
Copy link
Copy Markdown
Collaborator Author

nj1973 commented Apr 8, 2026

/gcbrun

Copy link
Copy Markdown
Collaborator

@sundar-mudupalli-work sundar-mudupalli-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. great work

@nj1973 nj1973 merged commit ff3573f into develop Apr 9, 2026
6 checks passed
@nj1973 nj1973 deleted the 1706-custom-query-db2-precision-and-scale branch April 9, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom query row validation on Db2 loses precision and scale

2 participants