fix: custom query row validation on Db2 loses precision and scale#1727
Merged
fix: custom query row validation on Db2 loses precision and scale#1727
Conversation
Collaborator
Author
|
/gcbrun |
sundar-mudupalli-work
approved these changes
Apr 9, 2026
Collaborator
sundar-mudupalli-work
left a comment
There was a problem hiding this comment.
Thank you. great work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes an issue where custom query row validation on Db2 loses decimal precision and scale because it was ignoring cursor.description values.
Updated
_get_type()to receive the entire column tuple, rather than just the type string, and extracted precision and scale. This mimics how PostgreSQL and Oracle backends extract type sizes.Issues to be closed
Closes #1706
Checklist
CONTRIBUTINGGuide.tests/local_check.shscript)