Fix local repo paths in contributor guidance.#253
Fix local repo paths in contributor guidance.#253deorbit wants to merge 4 commits intoGoogleContainerTools:masterfrom deorbit:master
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
CLA signed and sealed. |
|
CLAs look good, thanks! |
|
With my previous commit, import paths won't work, so I've changed guidance further to clone into $GOPATH/src/github.com/GoogleContainerTools and set the contributor's repo as a remote there after guidance by @campoy (http://blog.campoy.cat/2014/03/github-and-go-forking-pull-requests-and.html) |
|
The reason this didn't work originally is because we were missing the last part of the directory path in the should be That should make the flow we were trying to specify work, could you just update the original clone path? |
Configuring the repository will fail with the given paths (will clone into $GOPATH/src/github.com/GoogleContainerTools, subsequent
cdandgit remote addwill fail).