This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Fix unintended variable shadowing#263
Merged
dlorenc merged 1 commit intoGoogleContainerTools:masterfrom Oct 17, 2018
Merged
Conversation
davidcassany
requested review from
aaron-prindle,
dlorenc and
nkubala
as code owners
Contributor
Author
|
@nkubala a gentle ping for an easy-to-do review |
dlorenc
approved these changes
Oct 17, 2018
Contributor
Author
|
@dlorenc thanks! 👍 |
Contributor
|
@davidcassany so sorry I missed this review...Github notifications strike again 😢 |
Contributor
Author
No problem ;) |
Contributor
Author
|
@nkubala would it be possible to make a new minor release including last couple merges in master? I'd like to include them in the openSUSE contiainer-diff package and having it tagged in version is helpful for the Open Build Service. |
Contributor
|
@davidcassany definitely, I'll do one today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It fixes is an embarrassing mistake I did. This issue shouldn't have ever escaped my radar.