[Bugfix] fix missing 'finish_reason': null in streaming chat (#19662)#2266
Merged
czhu15 merged 1 commit intoHabanaAI:aice/v1.22.0from Apr 28, 2026
Merged
Conversation
…oject#19662) Signed-off-by: chaunceyjiang <chaunceyjiang@gmail.com> (cherry picked from commit 836d4ce)
xhaihao
requested review from
PatrykWo,
afierka-intel,
jikunshang,
kzawora-intel,
madamczyk-intel,
mgawarkiewicz-intel,
michalkuligowski,
mswiniarsk and
xuechendi
as code owners
Author
|
@czhu15 could you take a look at this PR ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 836d4ce)
It was changed in commit 05a4324 then it was fixed in commit 836d4ce on https://github.com/vllm-project/vllm. aice/v1.22.0 has 05a4324, hence we should apply 836d4ce to aice/v1.22.0 too, otherwise the reasoning content is displayed incorrectly in streaming chat.