Packaging and other cleanup#159
Merged
alanbriolat merged 13 commits intoHackSoc:masterfrom Jun 8, 2019
Merged
Conversation
1592697 to
343bc54
Compare
Also use coveralls-python instead of python-coveralls.
cb07c57 to
d78c71b
Compare
LordAro
reviewed
Jun 8, 2019
|
|
||
| # Whitelist specific files | ||
| !src/**/* | ||
| !tests/**/* |
Member
There was a problem hiding this comment.
i thought we didn't want tests in the docker?
Member
Author
There was a problem hiding this comment.
Don't want tests in a Python package (e.g. bdist_wheel), but they are deliberately in the Docker image so that tests get run inside the image as part of the Docker Hub build process. That way we have confidence that the produced image will run the bot correctly.
(There may be better ways to run tests without leaving them in the image, but I couldn't figure out a better one yet.)
LordAro
approved these changes
Jun 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overhaul and cleanup of project toolchain:
csbot/tosrc/csbot/: prevent accidental test behaviour from current directory being insys.pathcsbot/test/totests/: better separation of tests from code, don't ship tests during packagingsetup.pytoxfor testing multiple Python versionstoxbut also still use the build matrixtox.ini, triggered ifcoveralls"factor" is in test environment name (e.g.py36-coveralls)UIDandGIDconfigurable withdocker build --build-arg ...).dockerignoreas a whitelist