Conversation
- Remove unused tab.js and page at submissions/summary - There are some html wrapping updates to make the code readible and git diff friendly
theskumar
commented
Apr 19, 2025
Comment on lines
+91
to
+108
| x-data="{ | ||
| closeArchiveOutside(e){ | ||
| if (e.currentTarget == e.target){ | ||
| $refs.dialogArchive.close() | ||
| } | ||
| }, | ||
| closeReminderOutside(e){ | ||
| if (e.currentTarget == e.target){ | ||
| $refs.dialogReminder.close() | ||
| } | ||
| }, | ||
| closeMetaTermsOutside(e){ | ||
| if (e.currentTarget == e.target){ | ||
| $refs.dialogMetaTerms.close() | ||
| } | ||
| } | ||
| }" | ||
| {# fmt:on #} |
Member
Author
There was a problem hiding this comment.
@frjo doesn't look like this used anywhere, maybe it was not cleaned during htmx upgrade? Can you confirm this can be removed?
Member
There was a problem hiding this comment.
@theskumar No, this (x-data part) is no longer in use and can be removed.
frjo
approved these changes
Apr 21, 2025
Comment on lines
+91
to
+108
| x-data="{ | ||
| closeArchiveOutside(e){ | ||
| if (e.currentTarget == e.target){ | ||
| $refs.dialogArchive.close() | ||
| } | ||
| }, | ||
| closeReminderOutside(e){ | ||
| if (e.currentTarget == e.target){ | ||
| $refs.dialogReminder.close() | ||
| } | ||
| }, | ||
| closeMetaTermsOutside(e){ | ||
| if (e.currentTarget == e.target){ | ||
| $refs.dialogMetaTerms.close() | ||
| } | ||
| } | ||
| }" | ||
| {# fmt:on #} |
Member
There was a problem hiding this comment.
@theskumar No, this (x-data part) is no longer in use and can be removed.
Member
|
Nice cleanup, forgot that we no longer have tabs in the old sense. Just remove the x-data left over code and we can merge this in. |
Member
Author
|
@frjo should be good to merge after we have the blessings from our CI god! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tabs.jsand page atsubmissions/summarypage (non-functional)git difffriendly.