Conversation
Member
|
I get this error:
|
theskumar
force-pushed
the
typos
branch
2 times, most recently
from
f6fa55a to
a3d6331
Compare
Member
Author
|
@frjo can you give it a try again? |
Member
|
@theskumar Issues fixed. It's satisfying to see these spelling fixes! Nice addition to pre-commit so we catch the misspellings early. |
frjo
approved these changes
Apr 21, 2025
frjo
added
Type: Enhancement
Member
Author
|
I was a bit surprised by how many issues it was able to find—no false positives, except at the obvious paths that are excluded now. The PR is rebased now. |
Used pyproject.yml to file exclusions This packages is quite fast and has very low false positives. Given the number typos worth keeping it was able to find, I think it will be quite helpful for it to be part of our pre-commit and lint pipeline. It's quite easy to add new spellings or regex based ignore rules. https://github.com/crate-ci/typos
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This package is quite fast and has very low false positives.
Given the number typos worth keeping it was able to find, I think it will be quite helpful for it to be part of our pre-commit and lint pipeline. It's quite easy to add new spellings or regex-based ignore rules.
The exclusion and typo rules can be add to
pyproject.yml.Read more at https://github.com/crate-ci/typos