Conversation
Contributor
Author
|
As we move away from jQuery it might be nice to check out a vanilla JS datepicker like https://air-datepicker.com too Edit: this was already mentioned in #4475 |
frjo
approved these changes
May 21, 2025
Member
frjo
left a comment
There was a problem hiding this comment.
Works well in my testing. Nice new submitted filter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4548. This handles an invalid date the same as invalid/non-existent query params rather than erroring out.
In the long term, it would be better to indicate to the user that something wasn't right with their query though or no results were brought.When an invalid query is entered, it'll show the no results prompt!I also added the submitted drop down filter, as staff have been using that a bit recently
Test Steps
submitted:>=205-04-01 submitted:<=2025-04-30