Skip to content

Better error handling for dates, added submitted filter criteria#4549

Merged
frjo merged 3 commits intomainfrom
enhancement/all-submissions-updated-submitted-improvements
May 22, 2025
Merged

Better error handling for dates, added submitted filter criteria#4549
frjo merged 3 commits intomainfrom
enhancement/all-submissions-updated-submitted-improvements

Conversation

@wes-otf
Copy link
Copy Markdown
Contributor

@wes-otf wes-otf commented May 20, 2025

Fixes #4548. This handles an invalid date the same as invalid/non-existent query params rather than erroring out. In the long term, it would be better to indicate to the user that something wasn't right with their query though or no results were brought. When an invalid query is entered, it'll show the no results prompt!

I also added the submitted drop down filter, as staff have been using that a bit recently

Test Steps

  • Ensure putting an incorrectly formatted date in the query bar doesn't result in a 500 error
    • ie. submitted:>=205-04-01 submitted:<=2025-04-30
  • Ensure applications can be filtered by submitted date using the new drop down

@wes-otf wes-otf requested review from frjo and theskumar May 20, 2025 18:25
@wes-otf
Copy link
Copy Markdown
Contributor Author

wes-otf commented May 20, 2025

As we move away from jQuery it might be nice to check out a vanilla JS datepicker like https://air-datepicker.com too

Edit: this was already mentioned in #4475

Copy link
Copy Markdown
Member

@frjo frjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well in my testing. Nice new submitted filter.

@frjo frjo added Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter labels May 22, 2025
@frjo frjo merged commit d05b98d into main May 22, 2025
7 checks passed
@theskumar theskumar deleted the enhancement/all-submissions-updated-submitted-improvements branch July 20, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Enhancement This is an improvement of an existing thing (not a new thing, which would be a feature). Type: Patch Mini change, used in release drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Typing incorrect date into the query/search bar results in 500 error

2 participants