Conversation
wes-otf
approved these changes
Jun 10, 2025
Member
Author
Contributor
Member
|
The file name will have the hex but it should not change on each edit unless the file itself has changed. |
theskumar
added a commit
that referenced
this pull request
Jun 20, 2025
* origin/main: Fix report file path issue and duplicate file issue, Fix file path issue for Project and SOW Form (#4580) Use xhtml2pdf inplace of reportlab for submission pdf export (#4577) Fix co-applicant permission for Partners, Reviewers, and Community Reviewers (#4583) Migrate django-fsm to django-viewflow (#4561) Delete application comments with the application (#4585)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #4574
As reports are project documents so we added a different path for its files but we used ReportVersion instance checks and missed Report instances so reports files and its version files were having different path and were creating issues. We could solve it in that way as well but I realise as projects are also the extension of submission and we have been trying to merge them so keep everything similar with same url pattern.
Now it uses submission id to generate path and render the file similar to other submission files.
Now, it also handles the duplicate file issue on every upload. It was resolved for the application form but not for the report forms.
Test Steps
filename_<some hex code>.ext