Skip to content

Removed nested htmx triggering submission export on search#4597

Merged
frjo merged 1 commit intomainfrom
fix/export-submissions-triggered-on-query
Jul 6, 2025
Merged

Removed nested htmx triggering submission export on search#4597
frjo merged 1 commit intomainfrom
fix/export-submissions-triggered-on-query

Conversation

@wes-otf
Copy link
Copy Markdown
Contributor

@wes-otf wes-otf commented Jul 2, 2025

Fixes #4545. Removed the nested htmx that was triggering CSV exporting on query search or altering of draft/archive sliders.

Test Steps

  • Ensure that an htmx confirm prompt doesn't occur when searching in the query bar or using the draft/archive sliders

@wes-otf
Copy link
Copy Markdown
Contributor Author

wes-otf commented Jul 2, 2025

@theskumar should I merge this into the themes branch or wait until we get that merged?

@wes-otf wes-otf changed the base branch from main to themes July 2, 2025 16:48
@frjo
Copy link
Copy Markdown
Member

frjo commented Jul 3, 2025

@wes-otf Please merge it it to the themes PR, that is automatically deployed to test for the time being.

Nice fix!

@theskumar
Copy link
Copy Markdown
Member

We should get this fixed in main, and then I'll try to incorporate that in the themes, which will most likely be a new release.

@frjo
Copy link
Copy Markdown
Member

frjo commented Jul 3, 2025

@wes-otf We discussed this and bug fixes are better merged in to main. Can you rebase of main and then we can quickly test this and get it merged in.

@wes-otf wes-otf force-pushed the fix/export-submissions-triggered-on-query branch from b3d73d3 to 5de46c1 Compare July 3, 2025 13:46
@wes-otf wes-otf changed the base branch from themes to main July 3, 2025 13:47
@wes-otf
Copy link
Copy Markdown
Contributor Author

wes-otf commented Jul 3, 2025

It looks like a lot changed in the diff but really all that happened was I extracted the export submissions button out of the form element and wrapped the form and the button in a div

@wes-otf
Copy link
Copy Markdown
Contributor Author

wes-otf commented Jul 3, 2025

should be ready for main though, just cherrypicked the changes

@theskumar
Copy link
Copy Markdown
Member

theskumar commented Jul 3, 2025 via email

@wes-otf
Copy link
Copy Markdown
Contributor Author

wes-otf commented Jul 3, 2025

As it stands the bug still exists on test but I'll wait for you to check it out!

@frjo frjo added Type: Bug Bugs! Things that are broken :-/ Type: Minor Minor change, used in release drafter labels Jul 6, 2025
@frjo frjo merged commit 375397c into main Jul 6, 2025
theskumar added a commit that referenced this pull request Jul 8, 2025
* origin/main:
  Removed nested htmx triggering submission export on search (#4597)
  Fix Project lead visibility for org memeber like finance (#4599)
wes-otf added a commit to OpenTechFund/apply-app that referenced this pull request Aug 13, 2025
…4597)

Fixes HyphaApp#4545.

Removed the nested htmx that was triggering CSV exporting on query search or altering of draft/archive sliders.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Bug Bugs! Things that are broken :-/ Type: Minor Minor change, used in release drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accidental triggering of the export submissions button

3 participants