Fix deadline not showing on application form#4605
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue where the application form was not showing the deadline by updating the template to use the parent page’s next_deadline.
- Switched from
page.next_deadlinetopage.get_parent.specific.next_deadlinein the template.
Comments suppressed due to low confidence (2)
hypha/apply/funds/templates/funds/application_base.html:11
- No tests currently verify that the parent
next_deadlineis rendered on the application form; consider adding a view/template test to cover this scenario.
<span class="font-medium">{% trans 'Next deadline' %}: {{ page.get_parent.specific.next_deadline|date:'M j, Y' }}</span>
hypha/apply/funds/templates/funds/application_base.html:8
- The condition checks
page.end_date, which likely refers to the child form rather than the parent round. Update topage.get_parent.specific.end_date(or checknext_deadline) so the block actually displays when the parent has a deadline.
{% if page.end_date and page.get_parent.specific.show_deadline %}
Comment on lines
8
to
14
| {% if page.end_date and page.get_parent.specific.show_deadline %} | ||
| <p class="badge badge-info badge-soft badge-md"> | ||
| {% heroicon_micro 'calendar-days' class='size-4' aria_hidden=true %} | ||
| <span class="font-medium">{% trans 'Next deadline' %}: {{ page.next_deadline|date:'M j, Y' }}</span> | ||
| <span class="font-medium">{% trans 'Next deadline' %}: {{ page.get_parent.specific.next_deadline|date:'M j, Y' }}</span> | ||
| </p> | ||
| {% endif %} | ||
|
|
There was a problem hiding this comment.
[nitpick] Consider using a {% with parent=page.get_parent.specific %} block to avoid repeating get_parent.specific and improve template readability.
wes-otf
approved these changes
Jul 14, 2025
wes-otf
added
Type: Bug
wes-otf
pushed a commit
to OpenTechFund/apply-app
that referenced
this pull request
Aug 13, 2025
Noticed this small issue, where the deadline is not visible on the round form.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed this small issue, where the deadline is not visible on the round form.