Add option invert_polyhedron_faces for pvgridder.MeshStack3D.generate_mesh()#52
Merged
keurfonluu merged 3 commits intomainfrom Jan 6, 2026
Merged
Add option invert_polyhedron_faces for pvgridder.MeshStack3D.generate_mesh()#52keurfonluu merged 3 commits intomainfrom
invert_polyhedron_faces for pvgridder.MeshStack3D.generate_mesh()#52keurfonluu merged 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
invert_polyhedron_facesto ensure that polyhedral cells have no inverted faces (see cell_centers() returns wrong points i.e. outside of the convex hull of the mesh pyvista/pyvista#8129 (comment)). Note that VTK mesh validator may still flag some cells as having inverted faces. For instance:The report flags cell 103 as having inverted faces (meaning that their normals point inwards). However, when plotting the normal vectors of the faces of cell 103, we can see that the normals are pointing outwards.
With
invert_polyhedron_faces=False, the normal vectors point inwards, meaning that enabling this option correctly inverts the faces.Reminders:
invoke ruffto make sure the code follows the style guide,