-
Notifications
You must be signed in to change notification settings - Fork 34
Introducing AGENTS.md #2233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
napetrov
wants to merge
6
commits into
IntelPython:master
Choose a base branch
from
napetrov:dev/napetrov_agents
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Introducing AGENTS.md #2233
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d1e5c3a
first version of agents instructions
napetrov ffaa535
improved version of documentation
napetrov a4d95a0
instruction improvements
napetrov 09b2dc0
Trim root agent guide and drop tensor-specific agent docs
napetrov 66e3e75
dpctl/tests/AGENTS.md: remove elementwise references (tensor migration)
napetrov c099e59
Address ndgrigorian review: remove tensor-specific references
napetrov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| --- | ||
| applyTo: | ||
| - "dpctl/**/*.pyx" | ||
| - "dpctl/**/*.pxd" | ||
| - "dpctl/**/*.pxi" | ||
| --- | ||
|
|
||
| # Cython Instructions | ||
|
|
||
| See `dpctl/AGENTS.md` for full conventions. | ||
|
|
||
| ## Required Directives (after license) | ||
| ```cython | ||
| # distutils: language = c++ | ||
| # cython: language_level=3 | ||
| # cython: linetrace=True | ||
| ``` | ||
|
|
||
| ## Key Rules | ||
| - `cimport` for C-level, `import` for Python-level | ||
| - Store C refs as `_*_ref`, clean up in `__dealloc__` with NULL check | ||
| - Use `with nogil:` for blocking C operations |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| --- | ||
| applyTo: | ||
| - "**/*.py" | ||
| - "**/*.pyx" | ||
| - "**/*.pxd" | ||
| - "**/*.cpp" | ||
| - "**/*.hpp" | ||
| - "**/*.h" | ||
| --- | ||
|
|
||
| # DPCTL General Instructions | ||
|
|
||
| See `AGENTS.md` at repository root for project overview and architecture. | ||
| Each major directory has its own `AGENTS.md` with specific conventions. | ||
|
|
||
| ## Key References | ||
|
|
||
| - **Code style:** `.pre-commit-config.yaml`, `.clang-format`, `.flake8` | ||
| - **License:** Apache 2.0 with Intel copyright - match existing file headers | ||
|
|
||
| ## Critical Rules | ||
|
|
||
| 1. **Device compatibility:** Not all devices support fp64/fp16 - never assume availability | ||
| 2. **Queue consistency:** Memory operations must use compatible queues | ||
| 3. **Resource cleanup:** Clean up C resources in `__dealloc__` with NULL check | ||
| 4. **NULL checks:** Always check C API returns before use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| --- | ||
| applyTo: | ||
| - "libsyclinterface/**/*.h" | ||
| - "libsyclinterface/**/*.hpp" | ||
| - "libsyclinterface/**/*.cpp" | ||
| --- | ||
|
|
||
| # C API Instructions | ||
|
|
||
| See `libsyclinterface/AGENTS.md` for conventions. | ||
|
|
||
| ## Naming | ||
| `DPCTL<ClassName>_<MethodName>` (e.g., `DPCTLDevice_Create`) | ||
|
|
||
| ## Ownership annotations (see `include/syclinterface/Support/MemOwnershipAttrs.h`) | ||
| - `__dpctl_give` - caller must free | ||
| - `__dpctl_take` - function takes ownership | ||
| - `__dpctl_keep` - function only observes | ||
|
|
||
| ## Key Rules | ||
| - Annotate all parameters and returns | ||
| - Return NULL on failure | ||
| - Use `DPCTL_API` for exports |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| --- | ||
| applyTo: | ||
| - "dpctl/memory/**" | ||
| - "**/test_sycl_usm*.py" | ||
| --- | ||
|
|
||
| # USM Memory Instructions | ||
|
|
||
| See `dpctl/memory/AGENTS.md` for details. | ||
|
|
||
| ## USM Types | ||
| - `MemoryUSMDevice` - device-only (fastest) | ||
| - `MemoryUSMShared` - host and device accessible | ||
| - `MemoryUSMHost` - host memory, device accessible | ||
|
|
||
| ## Lifetime Rules | ||
| 1. Memory is queue-bound | ||
| 2. Keep memory alive until operations complete | ||
| 3. Views extend base memory lifetime |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| --- | ||
| applyTo: | ||
| - "dpctl/tests/**/*.py" | ||
| - "**/test_*.py" | ||
| --- | ||
|
|
||
| # Testing Instructions | ||
|
|
||
| See `dpctl/tests/AGENTS.md` for patterns. | ||
|
|
||
| ## Essential helpers (from `helper/_helper.py`) | ||
| ```python | ||
| get_queue_or_skip() # Create queue or skip | ||
| ``` | ||
|
|
||
| ## Focus | ||
| Test SYCL runtime objects (Device, Queue, Context, Event, Platform) and USM memory APIs. | ||
|
|
||
| **Note:** The `dpctl/tensor` module has been removed; do not reference tensor‑specific patterns. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| # AGENTS.md - AI Agent Guide for DPCTL | ||
|
|
||
| ## Purpose | ||
|
|
||
| This file is the top-level entry point for AI agents working in `IntelPython/dpctl`. | ||
| Use it to orient quickly, then follow directory-level `AGENTS.md` files for implementation details and local conventions. | ||
|
|
||
| ## Repository Scope | ||
|
|
||
| DPCTL provides Python bindings for SYCL runtime objects and supporting infrastructure. | ||
|
|
||
| High-level stack: | ||
|
|
||
| ``` | ||
| Python API -> Cython Bindings -> C API (libsyclinterface) -> SYCL Runtime | ||
| ``` | ||
|
|
||
| ## How to Work in This Repo | ||
|
|
||
| 1. Identify the directory you are changing. | ||
| 2. Read the nearest `AGENTS.md` for that directory. | ||
| 3. Keep changes local and minimal; avoid unrelated refactors. | ||
| 4. Validate behavior with targeted tests before broad test runs. | ||
|
|
||
| ## Directory Guide | ||
|
|
||
| | Directory | Guide | Notes | | ||
| |-----------|-------|-------| | ||
| | `dpctl/` | `dpctl/AGENTS.md` | Core SYCL Python bindings and Cython patterns | | ||
| | `dpctl/memory/` | `dpctl/memory/AGENTS.md` | USM memory model and ownership rules | | ||
| | `dpctl/program/` | `dpctl/program/AGENTS.md` | Program/kernel compilation APIs | | ||
| | `dpctl/utils/` | `dpctl/utils/AGENTS.md` | Device info, ordering, and profiling utilities | | ||
| | `dpctl/tests/` | `dpctl/tests/AGENTS.md` | Test conventions for SYCL objects and memory APIs | | ||
| | `libsyclinterface/` | `libsyclinterface/AGENTS.md` | C API contracts and ABI-safe patterns | | ||
|
|
||
| ## Global Constraints | ||
|
|
||
| - Match existing Apache 2.0 + Intel header style for source files. | ||
| - Respect style tooling from `.pre-commit-config.yaml`, `.clang-format`, and `.flake8`. | ||
| - Do not assume all devices support fp64/fp16. | ||
| - Preserve queue/device compatibility checks and explicit error paths. | ||
| - Keep memory/resource cleanup explicit and safe. | ||
|
|
||
| ## Notes on GitHub Copilot Instructions | ||
|
|
||
| Files under `.github/instructions/*.instructions.md` are entry points for Copilot behavior. | ||
| They should stay concise and reference authoritative `AGENTS.md` files rather than duplicating full guidance. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| # dpctl/ - Core SYCL Bindings | ||
|
|
||
| ## Purpose | ||
|
|
||
| Python/Cython wrappers for SYCL runtime objects: Device, Queue, Context, Event, Platform. | ||
|
|
||
| ## Key Files | ||
|
|
||
| | File | Purpose | | ||
| |------|---------| | ||
| | `_sycl_device.pyx` | `SyclDevice` wrapping `sycl::device` | | ||
| | `_sycl_queue.pyx` | `SyclQueue` wrapping `sycl::queue` | | ||
| | `_sycl_context.pyx` | `SyclContext` wrapping `sycl::context` | | ||
| | `_sycl_event.pyx` | `SyclEvent` wrapping `sycl::event` | | ||
| | `_sycl_platform.pyx` | `SyclPlatform` wrapping `sycl::platform` | | ||
| | `_sycl_device_factory.pyx` | Device enumeration and selection | | ||
| | `_sycl_queue_manager.pyx` | Queue management utilities | | ||
| | `_backend.pxd` | C API declarations from libsyclinterface | | ||
| | `enum_types.py` | Python enums for SYCL types | | ||
|
|
||
| ## Cython Conventions | ||
|
|
||
| ### Required Directives (after license header) | ||
| ```cython | ||
| # distutils: language = c++ | ||
| # cython: language_level=3 | ||
| # cython: linetrace=True | ||
| ``` | ||
|
|
||
| ### Extension Type Pattern | ||
| ```cython | ||
| cdef class SyclDevice: | ||
| cdef DPCTLSyclDeviceRef _device_ref # C reference | ||
|
|
||
| def __dealloc__(self): | ||
| if self._device_ref is not NULL: | ||
| DPCTLDevice_Delete(self._device_ref) | ||
|
|
||
| cdef DPCTLSyclDeviceRef get_device_ref(self): | ||
| return self._device_ref | ||
| ``` | ||
|
|
||
| ### Key Rules | ||
| - Store C references as `_*_ref` attributes | ||
| - Always clean up in `__dealloc__` with NULL check | ||
| - Use `with nogil:` for blocking C calls | ||
| - Check NULL before using C API returns | ||
|
|
||
| ### Exceptions | ||
| - `SyclDeviceCreationError` | ||
| - `SyclQueueCreationError` | ||
| - `SyclContextCreationError` | ||
|
|
||
| ## cimport vs import | ||
|
|
||
| ```cython | ||
| # cimport - C-level declarations (compile-time) | ||
| from ._backend cimport DPCTLSyclDeviceRef, DPCTLDevice_Create | ||
|
|
||
| # import - Python-level (runtime) | ||
| from . import _device_selection | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| # dpctl/memory/ - USM Memory Management | ||
|
|
||
| ## Purpose | ||
|
|
||
| Python classes for SYCL Unified Shared Memory (USM) allocation. | ||
|
|
||
| ## USM Types | ||
|
|
||
| | Class | USM Type | Description | | ||
| |-------|----------|-------------| | ||
| | `MemoryUSMDevice` | Device | Device-only, fastest access | | ||
| | `MemoryUSMShared` | Shared | Host and device accessible | | ||
| | `MemoryUSMHost` | Host | Host memory, device accessible | | ||
|
|
||
| ## __sycl_usm_array_interface__ | ||
|
|
||
| All memory classes implement this protocol: | ||
| ```python | ||
| { | ||
| "data": (ptr, readonly_flag), | ||
| "shape": (nbytes,), | ||
| "strides": None, | ||
| "typestr": "|u1", | ||
| "version": 1, | ||
| "syclobj": queue | ||
| } | ||
| ``` | ||
|
|
||
| ## Memory Lifetime Rules | ||
|
|
||
| 1. **Queue-bound:** Memory tied to specific queue/context | ||
| 2. **Outlive operations:** Keep memory alive until operations complete | ||
| 3. **Views extend lifetime:** Views keep base memory alive | ||
|
|
||
| ## Key Files | ||
|
|
||
| | File | Purpose | | ||
| |------|---------| | ||
| | `_memory.pyx` | Memory class implementations | | ||
| | `_memory.pxd` | Cython declarations | | ||
| | `__init__.py` | Public API exports | |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # dpctl/program/ - SYCL Kernel Compilation | ||
|
|
||
| ## Purpose | ||
|
|
||
| Compile and manage SYCL kernels from OpenCL C or SPIR-V source. | ||
|
|
||
| ## Key Files | ||
|
|
||
| | File | Purpose | | ||
| |------|---------| | ||
| | `_program.pyx` | `SyclProgram`, `SyclKernel` extension types | | ||
| | `_program.pxd` | Cython declarations | | ||
| | `__init__.py` | Public API exports | | ||
|
|
||
| ## Classes | ||
|
|
||
| - **`SyclProgram`** - Compiled SYCL program containing one or more kernels | ||
| - **`SyclKernel`** - Individual kernel extracted from a program | ||
|
|
||
| ## Usage Pattern | ||
|
|
||
| ```python | ||
| from dpctl.program import create_program_from_source | ||
|
|
||
| source = """ | ||
| __kernel void add(__global float* a, __global float* b, __global float* c) { | ||
| int i = get_global_id(0); | ||
| c[i] = a[i] + b[i]; | ||
| } | ||
| """ | ||
|
|
||
| program = create_program_from_source(queue, source) | ||
| kernel = program.get_sycl_kernel("add") | ||
| ``` | ||
|
|
||
| ## Notes | ||
|
|
||
| - Programs are context-bound | ||
| - Follows same Cython patterns as core dpctl (see `../AGENTS.md`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| # dpctl/tests/ - Test Suite | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. in general, this should be rewritten without tensor: the focus of the test suite with tensor being removed is on functionality of Python-exposed SYCL objects |
||
|
|
||
| ## Purpose | ||
|
|
||
| pytest-based test suite for dpctl SYCL runtime objects and USM memory functionality. | ||
|
|
||
| **Note:** The `dpctl/tensor` module has been removed; focus testing on SYCL objects and memory APIs. | ||
|
|
||
| ## Key Files | ||
|
|
||
| | File | Purpose | | ||
| |------|---------| | ||
| | `conftest.py` | Fixtures and pytest configuration | | ||
| | `helper/_helper.py` | `get_queue_or_skip()` (queue creation helper) | | ||
|
|
||
| ## Essential Helpers | ||
|
|
||
| From `helper/_helper.py`: | ||
| ```python | ||
| get_queue_or_skip() # Create queue or skip test | ||
| ``` | ||
|
|
||
| ## Test Pattern (SYCL objects) | ||
|
|
||
| ```python | ||
| def test_device_creation(): | ||
| q = get_queue_or_skip() | ||
| dev = q.sycl_device | ||
| # ... test device properties and methods | ||
|
|
||
| def test_usm_allocation(): | ||
| q = get_queue_or_skip() | ||
| # Test USM memory allocation for supported data types | ||
| # ... | ||
| ``` | ||
|
|
||
| ## Critical Rules | ||
|
|
||
| 1. **Device compatibility:** Not all devices support fp64/fp16 – verify support before testing float64/complex128 memory operations. | ||
| 2. **Queue consistency:** Memory allocations and operations must use compatible queues. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # dpctl/utils/ - Utility Functions | ||
|
|
||
| ## Purpose | ||
|
|
||
| Helper utilities for device queries, execution context management, and ordering. | ||
|
|
||
| **Note:** The `dpctl/tensor` module has been removed; utilities specific to tensor operations are no longer present. | ||
|
|
||
| ## Key Files | ||
|
|
||
| | File | Purpose | | ||
| |------|---------| | ||
| | `_order_manager.py` | `OrderManager` for memory layout handling | | ||
| | `_intel_device_info.py` | Intel-specific device information | | ||
| | `_onetrace_context.py` | Tracing/profiling context manager | |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.