Sumeru / #469 - Surface push registration errors instead of failing silently#852
Open
sumeruchat wants to merge 1 commit intomasterfrom
Open
Sumeru / #469 - Surface push registration errors instead of failing silently#852sumeruchat wants to merge 1 commit intomasterfrom
sumeruchat wants to merge 1 commit intomasterfrom
Conversation
When pushIntegrationName is set to an invalid value, the registerDeviceToken API call fails but the error was silently swallowed in the native layer. This change implements the onTokenRegistrationFailed callback on both iOS and Android native modules to emit an event to the React Native layer. A console.error is always logged, and developers can optionally provide an onTokenRegistrationFailed callback in IterableConfig for programmatic error handling. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
|
Coverage Impact ⬇️ Merging this pull request will decrease total coverage on Modified Files with Diff Coverage (1)
🤖 Increase coverage with AI coding...🚦 See full report on Qlty Cloud » 🛟 Help
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
onTokenRegistrationFailedcallback on both iOS and Android native modules, which was previously empty (iOS) or missing (Android)handleTokenRegistrationFailedCalledevent from native to JS when push token registration failsconsole.errorwith a helpful message when registration fails, so developers see the error even without configuring a callbackonTokenRegistrationFailedcallback toIterableConfigfor programmatic error handlingTest plan
pushIntegrationNameand verify error is logged to consolepushIntegrationNamewithonTokenRegistrationFailedcallback and verify callback is invoked with reason🤖 Generated with Claude Code