Skip to content

Claude/fix rn sdk 469 5 fq38#853

Closed
davidtruong wants to merge 2 commits intomasterfrom
claude/fix-rn-sdk-469-5Fq38
Closed

Claude/fix rn sdk 469 5 fq38#853
davidtruong wants to merge 2 commits intomasterfrom
claude/fix-rn-sdk-469-5Fq38

Conversation

@davidtruong
Copy link
Copy Markdown

🔹 JIRA Ticket(s) if any

✏️ Description

Please provide a brief description of what this pull request does.

claude added 2 commits April 7, 2026 15:15
When autoPushRegistration is enabled, device token registration failures
(e.g., from invalid pushIntegrationName) were silently swallowed in the
native layer. This adds an onTokenRegistrationFailed callback to
IterableConfig that developers can use to detect and handle these errors.

Changes:
- Add onTokenRegistrationFailed optional callback to IterableConfig
- Add handleTokenRegistrationFailedCalled event name
- iOS: Implement onTokenRegistrationFailed delegate to emit event
- Android: Implement onTokenRegistrationFailed to emit event
- Wire up event listener in setupEventHandlers

https://claude.ai/code/session_017dWRachduo3ATqU37Ef3mh
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 7, 2026

Lines Statements Branches Functions
Coverage: 62%
62.99% (400/635) 40.15% (104/259) 61.23% (139/227)

@qltysh
Copy link
Copy Markdown

qltysh bot commented Apr 7, 2026

Qlty

Coverage Impact

⬇️ Merging this pull request will decrease total coverage on master by 0.08%.

Modified Files with Diff Coverage (1)

RatingFile% DiffUncovered Line #s
Coverage rating: A Coverage rating: A
src/core/classes/Iterable.ts50.0%1097-1100
Total50.0%
🤖 Increase coverage with AI coding...

In the `claude/fix-rn-sdk-469-5Fq38` branch, add test coverage for this new code:

- `src/core/classes/Iterable.ts` -- Line 1097-1100

🚦 See full report on Qlty Cloud »

🛟 Help
  • Diff Coverage: Coverage for added or modified lines of code (excludes deleted files). Learn more.

  • Total Coverage: Coverage for the whole repository, calculated as the sum of all File Coverage. Learn more.

  • File Coverage: Covered Lines divided by Covered Lines plus Missed Lines. (Excludes non-executable lines including blank lines and comments.)

    • Indirect Changes: Changes to File Coverage for files that were not modified in this PR. Learn more.

@davidtruong
Copy link
Copy Markdown
Author

Things are fixed

@davidtruong davidtruong closed this Apr 8, 2026
@davidtruong davidtruong deleted the claude/fix-rn-sdk-469-5Fq38 branch April 8, 2026 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants