fix: make @react-navigation/native an optional peer dependency#854
Closed
davidtruong wants to merge 1 commit intomasterfrom
Closed
fix: make @react-navigation/native an optional peer dependency#854davidtruong wants to merge 1 commit intomasterfrom
davidtruong wants to merge 1 commit intomasterfrom
Conversation
Users who do not use the IterableInbox component (or who use a different navigation library) should not be forced to install @react-navigation/native. - Mark @react-navigation/native, react-native-safe-area-context, and react-native-webview as optional in peerDependenciesMeta - Create a safe useIsFocused hook wrapper that gracefully falls back to returning true when @react-navigation/native is not installed - Update IterableInbox to use the wrapper instead of importing directly Closes #770 https://claude.ai/code/session_01SsKoAbA48hJk6cDmbrRGqc
❌ 1 blocking issue (1 total)
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| */ | ||
| export function useIsFocused(): boolean { | ||
| if (useIsFocusedFromNav) { | ||
| return useIsFocusedFromNav(); |
Author
|
Things are fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users who do not use the IterableInbox component (or who use a different navigation library) should not be forced to install @react-navigation/native.
Closes #770
https://claude.ai/code/session_01SsKoAbA48hJk6cDmbrRGqc
🔹 JIRA Ticket(s) if any
✏️ Description