allow serialization of embedded raw json#38
Merged
SphtKr merged 1 commit intoJSONAPIdotNET:masterfrom Jan 30, 2015
Merged
Conversation
Collaborator
|
Will merge, but yeah, I'm not sure if the minification is our job--seems like if the user is doing something this "raw" it should be their job, or leave it to Json.NET (which probably wouldn't do anything to it, I don't think). On the other hand, I wonder if we shouldn't find some way to validate the (outgoing) JSON--if the JSON pulled from the persistence layer is malformed, the whole payload will be unparsable. That could even be an attack vector...though that might be paranoia. |
SphtKr
added a commit
that referenced
this pull request
Jan 30, 2015
allow serialization of embedded raw json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #34
I took the opportunity to clean up that serializer integration test fixture file. The minification is now done inside the test, so if we need to modify the file, we won't go insane.
I also moved the minification utility into JSONAPI proper. The json sent from the client will now be minified during deserialization, before it reaches the ApiController. I could have gone either way on this one, but I felt that the format of the JSON during transit is no concern of the business layer. If it wants its JSON formatted in a certain way, it can deal with that itself after we are done with it.