disable make without explicit 1st-arg type, like make(2, 3)#5
Merged
disable make without explicit 1st-arg type, like make(2, 3)#5
Conversation
Having the shortcut `make(2, 3)` for `make(Array, 2, 3)`, which mirrors `rand(2, 3)`, is convenient, but the form `make(Int, 2, 3)` leads to ambiguities for types which take 2 integer args, e.g. `make(MyType, 2, 3)`. Let's favor simplicity for custom-defined types. Moreover, the terminology "make" makes sense when the first arg refers to the type to be "made", e.g. in `make(Int, 2, 3)` we didn't make an `Int`, but an array, so the meaning of "make" was lost.
rfourquet
force-pushed
the
remove-shortcuts
branch
from
e86f756 to
94028ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having the shortcut
make(2, 3)formake(Array, 2, 3), which mirrorsrand(2, 3), is convenient, but the formmake(Int, 2, 3)leads toambiguities for types which take 2 integer args, e.g.
make(MyType, 2, 3). Let's favor simplicity for custom-defined types.Moreover, the terminology "make" makes sense when the first arg
refers to the type to be "made", e.g. in
make(Int, 2, 3)we didn'tmake an
Int, but an array, so the meaning of "make" was lost.