PR: Add universal screw parameters to screws_tilt_adjust with backward compatibility#844
Open
GiacomoGuaresi wants to merge 24 commits intoKalicoCrew:mainfrom
Open
Conversation
dalegaard
requested changes
Feb 23, 2026
Contributor
Author
|
Hi @dalegaard , thanks a lot for the comments you left I agree with everything you pointed out. In the meantime, I’ll address the issues you mentioned. If you have any other suggestions or feedback, I’m more than happy to hear them. Thanks again for your feedback! |
dalegaard
requested changes
Feb 24, 2026
Co-authored-by: dalegaard <dalegaard@gmail.com>
dalegaard
requested changes
Feb 24, 2026
dalegaard
reviewed
Feb 25, 2026
dalegaard
requested changes
Feb 25, 2026
… boolean variables
Contributor
Author
|
Hi @dalegaard, I wanted to let you know that I'm back to work on this PR, sorry for the wait |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the
screws_tilt_adjustmodule universal by allowing any screw thread pitch, instead of being limited to predefined screw types.Previously, only specific screw types (
M3,M4,M5,M6,M8) could be used via thescrew_threadparameter.What Changed
New Universal Parameters
screw_factor– screw thread pitch in millimetersscrew_direction– rotation direction (CW/CCW)Backward Compatibility
screw_threadparameter continues to work unchangedSimplified Implementation
Documentation Updated
Config_Reference.mdWhy
The old implementation was restrictive: users with custom screw sizes (e.g.
M10,M12, or non-standard thread pitches) could not use the tool.This change enables universal screw support while maintaining full backward compatibility with all existing configurations.
Example Usage
Checklist