Add Buffer_Misc model group to separate buffers#553
Add Buffer_Misc model group to separate buffers#553bghgary merged 4 commits intoKhronosGroup:masterfrom YuuuZhang:Separate_Buffers
Conversation
|
|
bghgary
left a comment
bghgary
left a comment
There was a problem hiding this comment.
Looking good.
Also need to:
- Generate screenshots and discard all the generated screenshots except for the new Buffer_Misc because of #480.
- Validate models
If you are running vscode, you can do this from the debug dropdown.
| new Texture_Sampler(imageList), | ||
| new Animation_SamplerType(imageList), | ||
| new Instancing(imageList), | ||
| new Buffer_Misc(imageList), |
There was a problem hiding this comment.
This list is supposed to be sorted. Please put Buffer_Misc in the right place. Then in a separate PR fix the last two entries so that they are also correct.
There was a problem hiding this comment.
Got it. I will make Buffer_Misc in the right place.
And correct Animation_SamplerType and Instancing in another PR.
|
|
||
| public Buffer_Misc(List<string> imageList) | ||
| { | ||
| NoSampleImages = true; |
There was a problem hiding this comment.
Why no sample images for this group? Seems like we should have it.
There was a problem hiding this comment.
Because sample images do not affect separate buffers and animation display effect.
So I do not use sample images to make the geometry settings to be minimal.
But we can also add sample images and update it`s .md files.
| public Buffer_Misc(List<string> imageList) | ||
| { | ||
| NoSampleImages = true; | ||
| UseFigure(imageList, "NYI"); |
| { | ||
| var properties = new List<Property>(); | ||
| Runtime.MeshPrimitive meshPrimitive = MeshPrimitive.CreateSinglePlane(includeTextureCoords: false); | ||
| meshPrimitive.Material = new Runtime.Material |
There was a problem hiding this comment.
Why do you need a material?
3 participants
Intended to separate buffers into geometry data and animation data.
Fixes #440