aria-labelled by for LabeledField

[inveterateliterate]

from pa11y-ci:

• This fieldset element does not have a name available to an accessibility API. Valid names are: legend element, aria-label undefined, aria-labelledby undefined.
• Fieldset does not contain a legend element. All fieldsets should contain a legend element that describes a description of the field group.

[dpikt]

@chawes13 was the second point what you fixed in #384? (unreleased)

[inveterateliterate]

and if so @dpikt what's the release plan for v4? we can ignore this in our CI until then

[dpikt]

Well, it's been open since Jan 2019 😵I can prioritize getting it merged next week. I was trying to finish #410 first but I don't think that's happening any time soon.

[inveterateliterate]

it's not urgent! I know you're swamped. I will put a flag to ignore in CI for now

[dpikt]

Here's the v4 branch: #311

[chawes13]

@dpikt This issue would only be partially addressed by #384 (for radio and checkbox groups). While it does appear that a fieldset with a single input is valid HTML, it's not recommended according to WebAIM (excerpt below).

Fieldset and legend should only be used when a higher-level label is necessary. Single checkboxes or basic radio buttons that make sense from their labels alone do not require fieldset and legend.

Another source (UK Gov A11y blog), states:

You should not use the <fieldset> and <legend> when: You have a single form field that asks for a single piece of information.

I believe that this indicates that <fieldset> is not the appropriate element to be wrapping inputs except for Radio and Checkbox groups. Since v4 is unreleased, it's possible that we could include a change that swaps out the element for a div. I wonder how other design systems handle this - it might be worth doing more design research to figure out the most appropriate element.

cc: @inveterateliterate

[inveterateliterate]

thanks @chawes13 and @dpikt for now I just made a version of LabeledField in prosci-components and changed fieldset to div (won't link here because the repo is limited). I will revert back once v4 is published!