Fix/warnings issue #199 - Deprecation Warnings#203
Open
matthewdeanmartin wants to merge 2 commits intoLibraryOfCongress:masterfrom
Open
Fix/warnings issue #199 - Deprecation Warnings#203matthewdeanmartin wants to merge 2 commits intoLibraryOfCongress:masterfrom
matthewdeanmartin wants to merge 2 commits intoLibraryOfCongress:masterfrom
Conversation
matthewdeanmartin
changed the title
matthewdeanmartin
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #199
Codec open, as per docs is replaced by open.
MR uses a partial to set the encoding and strictness.
https://docs.python.org/3/library/codecs.html#codecs.open
Also explicitly sets flags arg name.
More MRs incoming because it was unnecessarily difficult to check if this broke anything.