Skip to content

<feature>[dpu-bm2]: support attaching novlan and vxlan network to baremetal2 instance#3691

Open
MatheMatrix wants to merge 1 commit into5.5.12from
sync/zstackio/cherry-pick-24998267
Open

<feature>[dpu-bm2]: support attaching novlan and vxlan network to baremetal2 instance#3691
MatheMatrix wants to merge 1 commit into5.5.12from
sync/zstackio/cherry-pick-24998267

Conversation

@MatheMatrix
Copy link
Copy Markdown
Owner

support attaching novlan and vxlan network to baremetal2 instance

Resolves/Related: ZSTAC-82781

Change-Id: I736d637a7168656a6c726c6769777a726e616974

(cherry picked from commit 2499826)

sync from gitlab !9553

…emetal2 instance

support attaching novlan and vxlan network to baremetal2 instance

Resolves/Related: ZSTAC-82781

Change-Id: I736d637a7168656a6c726c6769777a726e616974


(cherry picked from commit 2499826)
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: http://open.zstack.ai:20001/code-reviews/zstack-cloud.yaml (via .coderabbit.yaml)

Review profile: CHILL

Plan: Pro

Run ID: 714f2c93-8eff-4787-bf64-cf878a736f54

📥 Commits

Reviewing files that changed from the base of the PR and between 933931f and 46bf71f.

⛔ Files ignored due to path filters (3)
  • sdk/src/main/java/SourceClassMap.java is excluded by !sdk/**
  • sdk/src/main/java/org/zstack/sdk/BareMetal2DpuChassisConfig.java is excluded by !sdk/**
  • sdk/src/main/java/org/zstack/sdk/YuccaBareMetal2DpuChassisConfig.java is excluded by !sdk/**
📒 Files selected for processing (1)
  • utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java

概述

CloudOperationsErrorCode 类中新增四个公共静态字符串常量,用于裸金属实例相关的错误代码,分别为 ORG_ZSTACK_BAREMETAL2_INSTANCE_1009310096,无其他逻辑或流程变更。

变更

Cohort / File(s) 总结
错误代码常量
utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java
新增四个裸金属实例错误码常量(10093-10096),每个常量映射到对应的字符串值。

评估代码审查工作量

🎯 1 (Trivial) | ⏱️ ~3 分钟

诗歌

🐰 四声错误码,轻轻添上,
裸金属的故事,在代码中唱。
十百位的数字,标记着路,
简洁而纯粹,如同青草露。


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
Title check ❌ Error PR标题超过72字符的限制(85字符),不符合要求的格式长度要求。 缩短标题至72字符以内,例如:'[dpu-bm2]: add baremetal2 network attachment support'。
✅ Passed checks (2 passed)
Check name Status Explanation
Description check ✅ Passed PR描述与变更集相关,提及ZSTAC-82781和支持bare metal2实例网络附加的特性。
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch sync/zstackio/cherry-pick-24998267

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ast-grep (0.42.1)
utils/src/main/java/org/zstack/utils/clouderrorcode/CloudOperationsErrorCode.java

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant