Specification
The network/Connection.ts and derived classes are still using the old manual start booleans. These should have async-init applied as well. I recommend using CreateDestroy instead of start stop.
Make sure to update ForwardProxy and ReverseProxy as well as the entire connection object lifecycle is managed by these 2.
Because Connection is an abstract class, the pattern has to follow the same style as GRPCClient. The static creation function instead creates parameters used to construct the derived classes.
Additional context
Tasks
- Update the
Connection, ConnectionForward, ConnectionReverse and replace start/stop with CreateDestroy pattern
- Update
ForwardProxy and ReverseProxy with the new create destroy patterns used by Connection.
- Ensure that
network tests are working
- Ensure that
nodes tests are working
Specification
The
network/Connection.tsand derived classes are still using the old manual start booleans. These should have async-init applied as well. I recommend usingCreateDestroyinstead ofstartstop.Make sure to update
ForwardProxyandReverseProxyas well as the entire connection object lifecycle is managed by these 2.Because
Connectionis an abstract class, the pattern has to follow the same style asGRPCClient. The static creation function instead creates parameters used to construct the derived classes.Additional context
Tasks
Connection,ConnectionForward,ConnectionReverseand replace start/stop withCreateDestroypatternForwardProxyandReverseProxywith the new create destroy patterns used byConnection.networktests are workingnodestests are working