Skip to content

Develop#369

Merged
hjmeesho merged 3 commits intomainfrom
develop
Apr 27, 2026
Merged

Develop#369
hjmeesho merged 3 commits intomainfrom
develop

Conversation

@hjmeesho
Copy link
Copy Markdown
Contributor

@hjmeesho hjmeesho commented Apr 27, 2026

🔁 Pull Request Template – BharatMLStack

Please fill out the following sections to help us review your changes efficiently.

Context:

Give a brief overview of the motivation behind this change. Include any relevant discussion links (Slack, documents, tickets, etc.) that help reviewers understand the background and the issue being addressed.

Describe your changes:

Mention the changes made in the codebase.

Testing:

Please describe how you tested the code. If manual tests were performed - please explain how. If automatic tests were added or existing ones cover the change - please explain how did you run them.

Monitoring:

Explain how this change will be tracked after deployment. Indicate whether current dashboards, alerts, and logs are enough, or if additional instrumentation is required.

Rollback plan

Explain rollback plan in case of issues.

Checklist before requesting a review

  • I have reviewed my own changes?
  • Relevant or critical functionality is covered by tests?
  • Monitoring needs have been evaluated?
  • Any necessary documentation updates have been considered?

📂 Modules Affected

  • horizon (Real-time systems / networking)
  • online-feature-store (Feature serving infra)
  • trufflebox-ui (Admin panel / UI)
  • infra (Docker, CI/CD, GCP/AWS setup)
  • docs (Documentation updates)
  • Other: ___________

✅ Type of Change

  • Feature addition
  • Bug fix
  • Infra / build system change
  • Performance improvement
  • Refactor
  • Documentation
  • Other: ___________

📊 Benchmark / Metrics (if applicable)

Summary by CodeRabbit

  • New Features

    • Added gRPC UI service for interactive API testing and exploration.
    • Added comprehensive sample request payloads across all gRPC services.
    • Added helper page with service details and authentication requirements.
  • Improvements

    • Enhanced setup process with automatic Docker provisioning and gRPC service integration.
    • Extended activity tracking to capture attempt numbers for improved request routing.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 27, 2026

Caution

Review failed

Pull request was closed or merged during review

Walkthrough

This pull request extends the activity contract with an attempt field for tracking Temporal activity attempts, adds gRPC UI infrastructure via nginx proxy and grpcui services to docker-compose, provides comprehensive gRPC sample payloads across multiple services (inferflow, numerix, onfs, predator, skye), introduces an nginx helper page documenting sample requests, and enhances the startup script to provision gRPC UI services and configure proto file routing.

Changes

Cohort / File(s) Summary
Core Activity Contract
core/activity-contracts/activity/activity.go
Added Attempt field (int, optional in JSON) to ActivityInput struct to carry current Temporal activity attempt number for async plugin callbacks.
gRPC Infrastructure
quick-start/docker-compose.yml, quick-start/start.sh
Added grpc-proxy (nginx-based) and grpcui services with port mappings; enhanced startup script with Docker installation check, gRPC UI provisioning logic, proto file copying, nginx reverse-proxy config generation, and gRPC service/method documentation in output.
gRPC UI Documentation
quick-start/nginx/index.html
New helper page with service cards, metadata header instructions, expandable example request payloads for multiple BharatML services, and links to local gRPC UI endpoint.
Inferflow Service Samples
quick-start/grpc-samples/inferflow/InferPairWise.json, InferPointWise.json, RetrieveModelScore.json
Added JSON fixtures for pairwise ranking, pointwise ranking inference requests, and model score retrieval with schema definitions and sample data.
Numerix Service Samples
quick-start/grpc-samples/numerix/Compute.json
Added JSON configuration for entity score computation with dot product compute ID and pair input examples.
ONFS Service Samples
quick-start/grpc-samples/onfs/PersistFeatures.json, RetrieveDecodedResult.json, RetrieveFeatures.json
Added JSON files for feature persistence, retrieval, and decoding with entity schemas, feature groups, and sample product data.
Predator Service Samples
quick-start/grpc-samples/predator/ModelInfer.json, ServerLive.json, ServerMetadata.json
Added JSON samples for model inference requests with tensor definitions and server status/metadata endpoints.
Skye Service Samples
quick-start/grpc-samples/skye/getCandidateEmbeddingScores.json, getEmbeddingsForCandidates.json, getSimilarCandidates.json
Added JSON payloads for embedding score computation, candidate embedding retrieval, and similarity-based candidate lookup.
🚥 Pre-merge checks | ✅ 1
✅ Passed checks (1 passed)
Check name Status Explanation
Dynamic Configuration Validation ✅ Passed No files matching the application-dyn-*.yml pattern exist in the repository, and no changes to such files are present in this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 golangci-lint (2.11.4)

level=error msg="[linters_context] typechecking error: pattern ./...: directory prefix . does not contain main module or its selected dependencies"


Comment @coderabbitai help to get the list of available commands and usage tips.

@hjmeesho hjmeesho merged commit 9f770f9 into main Apr 27, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants