Conversation
The Yarn audit failure has been addressed by ignoring the flagged security advisory. It is a ReDoS advisory, which doesn't present a risk for us (it's not used for a server, so there is no way for an attacker to impact our availability). The audit file has been slightly reorganized to remove an obsolete comment, and to place the explanations above each entry rather than below.
Gudahtt
added
the
No QA Needed
|
Kudos, SonarCloud Quality Gate passed!
|
metamaskbot
added
the
release-7.3.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
The Yarn audit failure has been addressed by ignoring the flagged security advisory. It is a ReDoS advisory, which doesn't present a risk for us (it's not used for a server, so there is no way for an attacker to impact our availability).
The audit file has been slightly reorganized to remove an obsolete comment, and to place the explanations above each entry rather than below.
Issue
None
Checklist