Added ability to include NRPT records to NameServers list automatical…#114
Merged
MichaConrad merged 4 commits intoMichaCo:devfrom May 17, 2021
Merged
Added ability to include NRPT records to NameServers list automatical…#114MichaConrad merged 4 commits intoMichaCo:devfrom
MichaConrad merged 4 commits intoMichaCo:devfrom
Conversation
MichaConrad
requested changes
May 16, 2021
Collaborator
MichaConrad
left a comment
MichaConrad
left a comment
There was a problem hiding this comment.
Looks pretty good overall, but I think we can simplify it by removing the configuration flags / options.
Collaborator
|
I actually didn't know about that new rule in .NET5 Or those new attributes... Seems fancy |
Collaborator
|
never mind, you fixed it already ;) |
Contributor
Author
|
Yeah, this rule is new to me too. Was easy enough to fix though. |
MichaConrad
approved these changes
May 17, 2021
Collaborator
MichaConrad
left a comment
MichaConrad
left a comment
There was a problem hiding this comment.
Looks good, I tested it also locally on Windows and Linux, seems all fine.
Thanks a lot again for the contribution @SteveSyfuhs !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ly on Windows