Skip to content

Add support for SSHFP#30

Merged
MichaConrad merged 1 commit intoMichaCo:devfrom
xudonax:dev
Aug 15, 2018
Merged

Add support for SSHFP#30
MichaConrad merged 1 commit intoMichaCo:devfrom
xudonax:dev

Conversation

@xudonax
Copy link
Copy Markdown
Contributor

@xudonax xudonax commented Jul 9, 2018

At the moment SSHFP is not supported, this pull requests adds support. This code is based on RFC 4255 which defines the basic implementation, RFC 6594 which adds ECDSA and SHA-256 support, and finally RFC 7479 which adds Ed25519 support.

If any changes need to be done, please let me know.

At the moment SSHFP is not supported, this pull requests adds support. This code is based on [RFC 4255](https://tools.ietf.org/html/rfc4255) which defines the basic implementation, [RFC 6594](https://tools.ietf.org/html/rfc6594) which adds ECDSA and SHA-256 support, and finally [RFC 7479](https://tools.ietf.org/html/rfc7479) which adds Ed25519 support.
@xudonax
Copy link
Copy Markdown
Contributor Author

xudonax commented Jul 9, 2018

The tests fail because there is no SSHFP record in the ZoneData byte array in TestMessageHandler, located at test\DnsClient.Tests\DnsResponseParsingTests.cs at line 373. How would I go about adding a record to that byte array?

@MichaConrad
Copy link
Copy Markdown
Collaborator

@xudonax
thanks for the PR, looks good as far as I can tell. I'll take a closer look / merge later.
Don't worry about the failing test, that's not very friendly to change atm

Copy link
Copy Markdown
Collaborator

@MichaConrad MichaConrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@MichaConrad MichaConrad merged commit fc057d5 into MichaCo:dev Aug 15, 2018
MichaConrad added a commit that referenced this pull request Aug 15, 2018
@MichaConrad MichaConrad added this to the 1.2.0 milestone Aug 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants