Auto detect network name server changes#66
Merged
MichaConrad merged 6 commits intodevfrom Mar 17, 2020
Merged
Conversation
…orkChange event and by reacting to socket errors.
+ Keeping NetworkChange event handle for now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds two things
NetworkChangeevent to react on changing network adaptersNameServer.ResolveNameServersto check if the configuration changedThe 2nd part gets triggered every ~60 seconds on the next Query call.
The 2nd part is needed because
NetworkChangeevents seem to not work on non-windows systems and changing just the DNS server entries in your network adapter also doesn't trigger any event.The event only triggers if the network adapter got en-/dis-abled or a new one was added for example.
All this is disabled if
LookupClientOptions.AutoResolveNameServersis not used/false.Also slightly changed the legacy property setters to use the new variable
_originalOptionsinstead of the (anyways bad) copy logic I had before.Plus unit tests for the backward compatibility check of those properties where I actually found a bug (one method wasn't set correctly).