add piggyback to all stores#257
Merged
digitalbuddha merged 3 commits intomainfrom Feb 4, 2021
Merged
Conversation
added 2 commits
February 3, 2021 15:26
Codecov Report
@@ Coverage Diff @@
## main #257 +/- ##
============================================
- Coverage 83.02% 83.00% -0.02%
+ Complexity 184 182 -2
============================================
Files 48 48
Lines 860 859 -1
Branches 129 129
============================================
- Hits 714 713 -1
Misses 80 80
Partials 66 66
Continue to review full report at Codecov.
|
eyalgu
previously approved these changes
Feb 3, 2021
| * act like a [SourceOfTruth] in the lack of a [SourceOfTruth] provided by the developer. | ||
| */ | ||
| private val enablePiggyback: Boolean = sourceOfTruth == null | ||
| private val enablePiggyback: Boolean = true |
| class RefreshTest { | ||
|
|
||
| @Test | ||
| fun refreshWithError() = runBlocking { |
Contributor
There was a problem hiding this comment.
can you add a test with no SOT case
eyalgu
approved these changes
Feb 3, 2021
rallat
pushed a commit
that referenced
this pull request
Aug 13, 2021
* add piggyback to all stores * lint * pr feedback Co-authored-by: miken <miken@dropbox.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #124 and #254
Currently, stores will only emit more than one error if a source of truth is not set.
One too many users have gotten confused by current behavior.
This diff makes behavior same for stores with and without source of truth.
End result is pull to refresh that uses store.fresh as side effect will work closer to user expectations
@yigit @eyalgu