M5atom Matrix and S3 migrate MPU6886 from pins/i2c to Ecma-419#1600
Open
stc1988 wants to merge 3 commits intoModdable-OpenSource:publicfrom
Open
M5atom Matrix and S3 migrate MPU6886 from pins/i2c to Ecma-419#1600stc1988 wants to merge 3 commits intoModdable-OpenSource:publicfrom
stc1988 wants to merge 3 commits intoModdable-OpenSource:publicfrom
Conversation
Collaborator
[sample.gyroscope.x, sample.gyroscope.y] = [sample.gyroscope.y * -1, sample.gyroscope.x];That's a subtle way to get a hidden temporary variable. ;) |
Contributor
Author
|
ChatGPT is much more of a JavaScript expert than I am. |
Collaborator
|
For those of your following along at home, here's a backgrounder. |
Contributor
Author
|
In this PR, the main focus is on resolving the I2C conflict, but if we are to fully migrate to ECMA-419, I think it would be necessary to create common modules for things like buttons as well. What do you think? |
Collaborator
We are. Still considering the time line, but I expect it to be this calendar year. (Don't panic... it will not be a surprise!)
Absolutely. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mixing pins/i2c with ECMA-419 I²C on the devices causes a conflict error.
Therefore, as a first step, this PR migrates devices that require minimal changes to ECMA-419 I²C. Please let me know if you have any concerns.