Support additional Slurm parameters#14701
Merged
bdubauski merged 7 commits intoNVIDIA-NeMo:llmb-nemo-r2.4.0from Sep 10, 2025
Merged
Support additional Slurm parameters#14701bdubauski merged 7 commits intoNVIDIA-NeMo:llmb-nemo-r2.4.0from
bdubauski merged 7 commits intoNVIDIA-NeMo:llmb-nemo-r2.4.0from
Conversation
bdubauski
requested review from
chtruong814,
ko3n1g,
pablo-garay and
thomasdhc
as code owners
github-actions
bot
added
core
github-actions
bot
removed
core
Signed-off-by: bdubauski <bdubauski@users.noreply.github.com>
bdubauski
requested review from
nv-mollys
and removed request for
chtruong814,
ko3n1g,
pablo-garay and
thomasdhc
added 2 commits
September 9, 2025 14:39
…-nemo into support-additional-params
nv-mollys
approved these changes
Sep 10, 2025
bdubauski
merged commit 763ffa8
into
NVIDIA-NeMo:llmb-nemo-r2.4.0
22 of 29 checks passed
bdubauski
added a commit
to bdubauski/llmb-nemo
that referenced
this pull request
Sep 16, 2025
* support additional slurm params and test with nemotron4 * fixed parsing of slurm params * fix incorrect parsing due to fallback * add support for all performance scripts * Apply isort and black reformatting Signed-off-by: bdubauski <bdubauski@users.noreply.github.com> * remove unused import --------- Signed-off-by: bdubauski <bdubauski@users.noreply.github.com> Co-authored-by: Barys Dubauski <bdubauski@nvdia.com> Co-authored-by: bdubauski <bdubauski@users.noreply.github.com>
8 tasks
bdubauski
added a commit
to bdubauski/llmb-nemo
that referenced
this pull request
Sep 16, 2025
* support additional slurm params and test with nemotron4 * fixed parsing of slurm params * fix incorrect parsing due to fallback * add support for all performance scripts * Apply isort and black reformatting Signed-off-by: bdubauski <bdubauski@users.noreply.github.com> * remove unused import --------- Signed-off-by: bdubauski <bdubauski@users.noreply.github.com> Co-authored-by: Barys Dubauski <bdubauski@nvdia.com> Co-authored-by: bdubauski <bdubauski@users.noreply.github.com>
bdubauski
added a commit
that referenced
this pull request
Sep 16, 2025
* Support additional Slurm parameters (#14701) * support additional slurm params and test with nemotron4 * fixed parsing of slurm params * fix incorrect parsing due to fallback * add support for all performance scripts * Apply isort and black reformatting Signed-off-by: bdubauski <bdubauski@users.noreply.github.com> * remove unused import --------- Signed-off-by: bdubauski <bdubauski@users.noreply.github.com> Co-authored-by: Barys Dubauski <bdubauski@nvdia.com> Co-authored-by: bdubauski <bdubauski@users.noreply.github.com> * restore custom_env_vars parameter passthrough --------- Signed-off-by: bdubauski <bdubauski@users.noreply.github.com> Co-authored-by: Barys Dubauski <bdubauski@nvdia.com> Co-authored-by: bdubauski <bdubauski@users.noreply.github.com>
bdubauski
added a commit
to bdubauski/llmb-nemo
that referenced
this pull request
Sep 18, 2025
* support additional slurm params and test with nemotron4 * fixed parsing of slurm params * fix incorrect parsing due to fallback * add support for all performance scripts * Apply isort and black reformatting Signed-off-by: bdubauski <bdubauski@users.noreply.github.com> * remove unused import --------- Signed-off-by: bdubauski <bdubauski@users.noreply.github.com> Co-authored-by: Barys Dubauski <bdubauski@nvdia.com> Co-authored-by: bdubauski <bdubauski@users.noreply.github.com> Signed-off-by: Barys Dubauski <bdubauski@nvdia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
The
Update branchbutton must only be pressed in very rare occassions.An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.
What does this PR do ?
Primary goal is to allow submission of LLM recipe jobs on specific slurm nodes
Collection: scripts/performance/llm
Changelog
Usage
GitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information