Skip to content

unset weights_only=False#15312

Merged
dimapihtar merged 2 commits intomainfrom
dpykhtar/fix_torch_load
Jan 26, 2026
Merged

unset weights_only=False#15312
dimapihtar merged 2 commits intomainfrom
dpykhtar/fix_torch_load

Conversation

@dimapihtar
Copy link
Copy Markdown
Collaborator

Important

The Update branch button must only be pressed in very rare occassions.
An outdated branch is never blocking the merge of a PR.
Please reach out to the automation team before pressing that button.

What does this PR do ?

unsets weight_only=False HFCheckpointIO's load_checkpoint.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: dimapihtar <dpihtar@gmail.com>
@github-actions
Copy link
Copy Markdown
Contributor

[🤖]: Hi @dimapihtar 👋,

We wanted to let you know that a CICD pipeline for this PR just finished successfully.

So it might be time to merge this PR or get some approvals.

//cc @chtruong814 @ko3n1g @pablo-garay @thomasdhc

@dimapihtar dimapihtar requested a review from akoumpa January 26, 2026 14:00
Copy link
Copy Markdown
Collaborator

@akoumpa akoumpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@dimapihtar dimapihtar merged commit 156f292 into main Jan 26, 2026
57 checks passed
@dimapihtar dimapihtar deleted the dpykhtar/fix_torch_load branch January 26, 2026 14:07
@chtruong814 chtruong814 added the r2.6.0 Cherry-pick label for the r2.6.0 release branch label Jan 28, 2026
chtruong814 pushed a commit that referenced this pull request Jan 28, 2026
* unset weights_only=False

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix code style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

---------

Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
chtruong814 added a commit that referenced this pull request Jan 28, 2026
* unset weights_only=False



* fix code style



---------

Signed-off-by: dimapihtar <dpihtar@gmail.com>
Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Co-authored-by: Dmytro Pykhtar <37850217+dimapihtar@users.noreply.github.com>
nune-tadevosyan pushed a commit to nune-tadevosyan/NeMo that referenced this pull request Mar 13, 2026
* unset weights_only=False

Signed-off-by: dimapihtar <dpihtar@gmail.com>

* fix code style

Signed-off-by: dimapihtar <dpihtar@gmail.com>

---------

Signed-off-by: dimapihtar <dpihtar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r2.6.0 Cherry-pick label for the r2.6.0 release branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants