Skip to content

Generate arguments from TransformerConfig#2896

Merged
maanug-nv merged 17 commits intoNVIDIA:mainfrom
maanug-nv:maanug/transfcfg-generated-args-v2
Jan 30, 2026
Merged

Generate arguments from TransformerConfig#2896
maanug-nv merged 17 commits intoNVIDIA:mainfrom
maanug-nv:maanug/transfcfg-generated-args-v2

Conversation

@maanug-nv
Copy link
Copy Markdown
Contributor

@maanug-nv maanug-nv commented Jan 10, 2026

What does this PR do ?

Generate argparse arguments from TransformerConfig.

All changes to TransformerConfig or ModelParallelConfig are in an attempt to match existing arguments in arguments.py. Four categories:

  • Tweak the type annotation in the dataclass to help auto-generating arguments
  • Change the defaults in the dataclasses to match arguments.py so that auto-generated arguments exactly match existing arguments' behavior
  • Add metadata for argument generation, mainly tweaks to CLI flag name ('dest' should always match the name of the attr in the dataclass)
  • Tweak docstring. Sometimes adding info from the argument helpstring, sometimes making existing docstring more compatible as a helpstring (since docstrings will be used for helpstrings in auto-generated arguments).

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Jan 10, 2026

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@maanug-nv maanug-nv changed the title Maanug/transfcfg generated args v2 Generate arguments from TransformerConfig Jan 12, 2026
@maanug-nv maanug-nv force-pushed the maanug/transfcfg-generated-args-v2 branch from f159ba7 to 62d70ed Compare January 13, 2026 00:35
@maanug-nv maanug-nv self-assigned this Jan 13, 2026
@maanug-nv maanug-nv marked this pull request as ready for review January 13, 2026 01:36
@maanug-nv maanug-nv requested review from a team as code owners January 13, 2026 01:36
@ko3n1g ko3n1g requested a review from a team January 13, 2026 01:36
@ko3n1g ko3n1g added this to the Core 0.16 milestone Jan 13, 2026
@ericharper ericharper requested a review from ahmadki January 13, 2026 16:54
maanug-nv and others added 2 commits January 26, 2026 15:30
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
Signed-off-by: Maanu Grover <maanug@nvidia.com>
@maanug-nv maanug-nv mentioned this pull request Jan 29, 2026
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

complexity: medium enhancement New feature or request Expert Review [deprecated] Apply this label to indicate that your PR is ready for expert review. module: training

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants