Skip to content

added vllm fakequant export support#3050

Merged
jenchen13 merged 5 commits intoNVIDIA:mainfrom
kinjalpatel27:kinjal/modelopt_vllm_export
Mar 24, 2026
Merged

added vllm fakequant export support#3050
jenchen13 merged 5 commits intoNVIDIA:mainfrom
kinjalpatel27:kinjal/modelopt_vllm_export

Conversation

@kinjalpatel27
Copy link
Copy Markdown
Contributor

What does this PR do ?

Added support to export quantized checkpoint from examples/post_training/modelopt/ for vLLM fakequant in modelopt/examples/vllm_serve/vllm_serve_fakequant.py

⚠️ For major changes (either in lines of code or in its impact), please make sure to first share a design doc with the team. If you're unsure what's the best way to do so, contact the @mcore-oncall.

Contribution process

flowchart LR
    A[Pre-checks] --> B[PR Tests]
    subgraph Code Review/Approval
        C1[Expert Review] --> C2[Final Review]
    end
    B --> C1
    C2 --> D[Merge]
Loading

Pre-checks

  • I want this PR in a versioned release and have added the appropriate Milestone (e.g., Core 0.8)
  • I have added relevant unit tests
  • I have added relevant functional tests
  • I have added proper typing to my code Typing guidelines
  • I have added relevant documentation
  • I have run the autoformatter.sh on my PR

Code review

The following process is enforced via the CODEOWNERS file for changes into megatron/core. For changes outside of megatron/core, it is up to the PR author whether or not to tag the Final Reviewer team.

For MRs into `main` branch

Feel free to message or comment the @mcore-oncall to help accelerate your merge into main. The less complex your PR is, the faster it will be approved and merged!

(Step 1): Add PR label Expert Review

(Step 2): Collect the expert reviewers reviews

  1. Attach the Expert Review label when your PR is ready for review.
  2. GitHub auto-assigns expert reviewers based on your changes. They will get notified and pick up your PR soon.

⚠️ Only proceed to the next step once all reviewers have approved, merge-conflict are resolved and the CI is passing.
Final Review might get declined if these requirements are not fulfilled.

(Step 3): Final Review

  1. Add Final Review label
  2. GitHub auto-assigns final reviewers based on your changes. They will get notified and pick up your PR soon.

(Optional Step 4): Cherry-pick into release branch

If this PR also needs to be merged into core_r* release branches, after this PR has been merged, select Cherry-pick to open a new PR into the release branch.

For MRs into `dev` branch The proposed review process for `dev` branch is under active discussion.

MRs are mergable after one approval by either eharper@nvidia.com or zijiey@nvidia.com.

Merging your PR

Any member of core-adlr and core-nemo will be able to merge your PR.

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Jan 22, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@kinjalpatel27 kinjalpatel27 marked this pull request as ready for review January 22, 2026 23:31
@ko3n1g ko3n1g requested a review from a team January 22, 2026 23:32
@ChenhanYu ChenhanYu self-requested a review January 23, 2026 00:36
@Phlip79 Phlip79 added the Approved All necessary approvals have been made label Mar 4, 2026
@Phlip79
Copy link
Copy Markdown
Member

Phlip79 commented Mar 4, 2026

Please fix conflicts.

@kinjalpatel27 kinjalpatel27 force-pushed the kinjal/modelopt_vllm_export branch from c4a8f80 to 79c51dd Compare March 20, 2026 15:14
@kinjalpatel27
Copy link
Copy Markdown
Contributor Author

Please fix conflicts.

@Phlip79 I have fixed the conflicts. thank you

@kinjalpatel27
Copy link
Copy Markdown
Contributor Author

@Phlip79 can you please review?

Copy link
Copy Markdown
Contributor

@dimapihtar dimapihtar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@dimapihtar
Copy link
Copy Markdown
Contributor

/ok to test e0b17dc

@svcnvidia-nemo-ci svcnvidia-nemo-ci added this to the Core 0.16 milestone Mar 24, 2026
@jenchen13 jenchen13 added this pull request to the merge queue Mar 24, 2026
@svcnvidia-nemo-ci
Copy link
Copy Markdown

🔄 Merge queue validation started!

You can track the progress here: https://github.com/NVIDIA/Megatron-LM/actions/runs/23501179852

Merged via the queue into NVIDIA:main with commit 99638d0 Mar 24, 2026
61 of 63 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Approved All necessary approvals have been made Run CICD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants