feat(server): add bundled docker compute driver#888
Draft
drew wants to merge 2 commits intofeat/supervisor-session-grpc-datafrom
Draft
feat(server): add bundled docker compute driver#888drew wants to merge 2 commits intofeat/supervisor-session-grpc-datafrom
drew wants to merge 2 commits intofeat/supervisor-session-grpc-datafrom
Conversation
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
|
🌿 Preview your docs: https://nvidia-preview-pr-888.docs.buildwithfern.com/openshell |
Signed-off-by: Drew Newberry <anewberry@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a bundled Docker compute driver to the gateway on top of the supervisor-relay base. This lets the gateway provision sandboxes directly through the local Docker daemon without exposing sandbox ports or spawning a separate Docker driver binary.
Related Issue
N/A
Changes
dockeras a supported compute driver kindopenshell-serverusing Bollard/sandboxvolumeTesting
mise run pre-commitpassesmise run pre-commitcurrently fails inpython:protobecausegrpc_tools.protocis not installed in the local Python environment. Rust formatting and the touched crate test suites passed:cargo fmt --allcargo test -p openshell-server --libcargo test -p openshell-core --libChecklist