Skip to content

fix: support zero-sized arrays as input to StridedMemoryView.from_cuda_array_interface#1397

Merged
leofang merged 5 commits intoNVIDIA:mainfrom
cpcloud:zero-size-arrays-smv
Dec 17, 2025
Merged

fix: support zero-sized arrays as input to StridedMemoryView.from_cuda_array_interface#1397
leofang merged 5 commits intoNVIDIA:mainfrom
cpcloud:zero-size-arrays-smv

Conversation

@cpcloud
Copy link
Copy Markdown
Contributor

@cpcloud cpcloud commented Dec 17, 2025

Add support for zero-sized array input to StridedMemoryView.from_cuda_array_interface. Closes #1396.

@cpcloud cpcloud requested review from leofang, rparolin and rwgk December 17, 2025 17:28
@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot Bot commented Dec 17, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@cpcloud cpcloud changed the title zero size arrays smv fix: support zero-sized arrays as input to StridedMemoryView.from_cuda_array_interface Dec 17, 2025
@cpcloud
Copy link
Copy Markdown
Contributor Author

cpcloud commented Dec 17, 2025

/ok to test

kkraus14
kkraus14 reviewed Dec 17, 2025
View reviewed changes
Comment thread cuda_core/cuda/core/experimental/_memoryview.pyx Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Dec 17, 2025

Doc Preview CI

🚀 View preview at
https://nvidia.github.io/cuda-python/pr-preview/pr-1397/

https://nvidia.github.io/cuda-python/pr-preview/pr-1397/cuda-core/

https://nvidia.github.io/cuda-python/pr-preview/pr-1397/cuda-bindings/

https://nvidia.github.io/cuda-python/pr-preview/pr-1397/cuda-pathfinder/


Preview will be ready when the GitHub Pages deployment is complete.

@cpcloud cpcloud requested a review from kkraus14 December 17, 2025 17:44
@leofang leofang added this to the cuda.core beta 10 milestone Dec 17, 2025
@cpcloud
Copy link
Copy Markdown
Contributor Author

cpcloud commented Dec 17, 2025

/ok to test

@cpcloud cpcloud enabled auto-merge (squash) December 17, 2025 18:03
@leofang leofang added bug Something isn't working P0 High priority - Must do! cuda.core Everything related to the cuda.core module labels Dec 17, 2025
@kkraus14 kkraus14 disabled auto-merge December 17, 2025 18:40
@kkraus14
Copy link
Copy Markdown
Collaborator

kkraus14 commented Dec 17, 2025

@cpcloud can you add a line to the 0.5.0 release notes for this and then we'll admin merge?

@cpcloud cpcloud force-pushed the zero-size-arrays-smv branch from c9e8d07 to f2db3ea Compare December 17, 2025 19:11
@cpcloud
Copy link
Copy Markdown
Contributor Author

cpcloud commented Dec 17, 2025

@kkraus14 done

@cpcloud cpcloud requested a review from kkraus14 December 17, 2025 19:12
@leofang
Copy link
Copy Markdown
Member

leofang commented Dec 17, 2025

Actually, thinking about this more... why do we need a release note entry for this fix? from_cuda_array_interface is new, anyway, so I wouldn't even call it a fix. This is more like a follow-up PR.

@leofang
Copy link
Copy Markdown
Member

leofang commented Dec 17, 2025

Actually, thinking about this more... why do we need a release note entry for this fix? from_cuda_array_interface is new, anyway, so I wouldn't even call it a fix. This is more like a follow-up PR.

@cpcloud @kkraus14 let's come up with a conclusion (mention or not) and I'll incorporate it in my follow-up PR.

@leofang
Copy link
Copy Markdown
Member

leofang commented Dec 17, 2025

oh... @cpcloud there is a merge conflict now because of #1377 😛 Was wondering why I can't admin-merge...

@kkraus14
Copy link
Copy Markdown
Collaborator

kkraus14 commented Dec 17, 2025

Actually, thinking about this more... why do we need a release note entry for this fix? from_cuda_array_interface is new, anyway, so I wouldn't even call it a fix. This is more like a follow-up PR.

@cpcloud @kkraus14 let's come up with a conclusion (mention or not) and I'll incorporate it in my follow-up PR.

I think this bug existed previously in the StridedMemoryView.__init__ before we had the from_* constructors.

@cpcloud cpcloud force-pushed the zero-size-arrays-smv branch from f2db3ea to 5a33e7a Compare December 17, 2025 20:02
@cpcloud
Copy link
Copy Markdown
Contributor Author

cpcloud commented Dec 17, 2025

I added some less specific language to the release notes.

@leofang
Copy link
Copy Markdown
Member

leofang commented Dec 17, 2025

/ok to test 5a33e7a

@leofang leofang enabled auto-merge (squash) December 17, 2025 20:04
@leofang
Copy link
Copy Markdown
Member

leofang commented Dec 17, 2025

Let me admin-merge since most of the CI runs pass and we hit the hanging issue, xref: #1377 (comment)

@leofang leofang disabled auto-merge December 17, 2025 21:28
@leofang leofang merged commit d407eb4 into NVIDIA:main Dec 17, 2025
66 of 80 checks passed
@cpcloud cpcloud deleted the zero-size-arrays-smv branch December 17, 2025 22:30
github-actions Bot pushed a commit that referenced this pull request Dec 18, 2025
Clean up PR preview folders for 4 closed/merged PRs
b204d86 
Removed preview folders for the following PRs:
- PR #1298
- PR #1397
- PR #1399
- PR #1401
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leofang leofang leofang approved these changes

@rwgk rwgk Awaiting requested review from rwgk

@rparolin rparolin Awaiting requested review from rparolin

@kkraus14 kkraus14 Awaiting requested review from kkraus14

Assignees

@cpcloud cpcloud

Labels

bug Something isn't working cuda.core Everything related to the cuda.core module P0 High priority - Must do!

Projects

None yet

Milestone

cuda.core beta 10

Development

Successfully merging this pull request may close these issues.

[BUG]: StridedMemoryView.from_cuda_array_interface doesn't support zero-sized arrays

3 participants

@cpcloud @kkraus14 @leofang