cuda.core.system: Naming improvements suggested in #1945#1946
Open
mdboom wants to merge 3 commits intoNVIDIA:mainfrom
Open
cuda.core.system: Naming improvements suggested in #1945#1946mdboom wants to merge 3 commits intoNVIDIA:mainfrom
mdboom wants to merge 3 commits intoNVIDIA:mainfrom
Conversation
mdboom
added
enhancement
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
rwgk
reviewed
Apr 23, 2026
|
|
||
| @property | ||
| def persistence_mode_enabled(self) -> bool: | ||
| def persistence_mode(self) -> bool: |
Contributor
There was a problem hiding this comment.
This is the only one that stands out to me as odd.
To be similar to is_c2c_enabled above, I'd expect is_persistence_enabled here. But really, is_persistence_mode_enabled would seem clearer. Then again, why are we dropping mode in is_c2c_mode_enabled? Overall my preference is:
is_c2c_mode_enabled
is_persistence_mode_enabled
Member
There was a problem hiding this comment.
Yes our convention for bool properties is is_<something>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This applies the non-controversial renaming suggestions in #1945 within cuda.core.system.