Skip to content

[no-ci] Update actions/labeler pin to include #917 fix#1971

Merged
rwgk merged 1 commit intomainfrom
update-labeler-pin
Apr 24, 2026
Merged

[no-ci] Update actions/labeler pin to include #917 fix#1971
rwgk merged 1 commit intomainfrom
update-labeler-pin

Conversation

@leofang
Copy link
Copy Markdown
Member

@leofang leofang commented Apr 24, 2026

Summary

  • Pin actions/labeler to e52e4fb which includes actions/labeler#917 — "Preserve manually added labels during workflow run and refine label sync logic"
  • The previous pin (634933e / v6.0.1) has a bug where labels added by other workflows during the same run can be removed even with sync-labels: false
  • This caused Needs-Restricted-Paths-Review (applied by restricted-paths-guard.yml) to be immediately stripped when pr-auto-label.yml ran concurrently — see [BUG]: actions/labeler interference with restricted-paths-guard.yml workflow #1967 for the full investigation
  • The fix has not been included in any actions/labeler release yet (latest is still v6.0.1), so we pin to a commit on main directly. We do not pin at the latest main HEAD because their CI on main currently fails. We should update to a tagged release once one is published.

Test plan

  • Open a test PR that touches a restricted path and verify Needs-Restricted-Paths-Review persists after the auto-labeler runs
  • Verify module labels (cuda.bindings, cuda.core, etc.) are still applied correctly

-- Leo's bot

The previous pin (v6.0.1, 634933e) has a bug where labels added
by other workflows during the same run can be removed even with
sync-labels: false.  This caused Needs-Restricted-Paths-Review
to be stripped immediately after being applied (see #1967).

Pin to e52e4fb which includes the fix from actions/labeler#917
("Preserve manually added labels during workflow run and refine
label sync logic").
@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot Bot commented Apr 24, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions Bot added the CI/CD CI/CD infrastructure label Apr 24, 2026
@leofang leofang marked this pull request as ready for review April 24, 2026 02:43
@leofang leofang self-assigned this Apr 24, 2026
@leofang leofang added this to the cuda.core v1.0.0 milestone Apr 24, 2026
@leofang leofang added the bug Something isn't working label Apr 24, 2026
@leofang leofang requested a review from rwgk April 24, 2026 02:44
@leofang leofang changed the title Update actions/labeler pin to include #917 fix [no-ci] Update actions/labeler pin to include #917 fix Apr 24, 2026
@rwgk
Copy link
Copy Markdown
Contributor

rwgk commented Apr 24, 2026

/ok to test

@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot Bot commented Apr 24, 2026

/ok to test

@rwgk, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@rwgk
Copy link
Copy Markdown
Contributor

rwgk commented Apr 24, 2026

/ok to test 62d8264

@rwgk rwgk enabled auto-merge (squash) April 24, 2026 03:28
@rwgk rwgk merged commit e29fa8f into main Apr 24, 2026
27 of 28 checks passed
@rwgk rwgk deleted the update-labeler-pin branch April 24, 2026 03:30
@github-actions
Copy link
Copy Markdown

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI/CD CI/CD infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: actions/labeler interference with restricted-paths-guard.yml workflow

2 participants