Add proxy config to standalone container registry#1090
Merged
ajdecon merged 2 commits intoNVIDIA:masterfrom Jan 18, 2022
Merged
Add proxy config to standalone container registry#1090ajdecon merged 2 commits intoNVIDIA:masterfrom
ajdecon merged 2 commits intoNVIDIA:masterfrom
Conversation
Contributor
|
@nuka137 : This looks reasonable to me! Can you please sign off on your commit as detailed in our CONTRIBUTING.md doc? And then I can merge the PR. |
Signed-off-by: Atsushi Nukariya <a.nukariya@jp.fujitsu.com>
0286d3e to
cd425ff
Compare
Contributor
Author
|
Recommitted about previous patch. |
ajdecon
approved these changes
Jan 12, 2022
ajdecon
suggested changes
Jan 12, 2022
Contributor
ajdecon
left a comment
There was a problem hiding this comment.
This actually appears to fail in the default case (without a proxy). If the variable isn't defined, Ansible won't run.
We use a different pattern in other tasks (example) that looks like this:
- name: apt install pciutils
apt: name=pciutils update_cache=yes
when: ansible_os_family == 'Debian'
environment: "{{ proxy_env if proxy_env is defined else {} }}"
And then define proxy_env if needed:
# proxy_env:
# http_proxy: '{{ http_proxy }}'
# https_proxy: '{{ https_proxy }}'
# no_proxy: '{{ no_proxy }}'
Can you convert this to either use the same proxy_env variable, or a similar pattern that works when no proxy is present?
Signed-off-by: Atsushi Nukariya <a.nukariya@jp.fujitsu.com>
Contributor
Author
|
Thanks. I fixed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current standalone container registry can not work on the proxy environment.
This PR enables us to specify the proxy configurations for standalone container registry.