Skip to content

ignore quotes around version when detecting version#2296

Open
rahulait wants to merge 1 commit intoNVIDIA:mainfrom
rahulait:fix-version-detection
Open

ignore quotes around version when detecting version#2296
rahulait wants to merge 1 commit intoNVIDIA:mainfrom
rahulait:fix-version-detection

Conversation

@rahulait
Copy link
Copy Markdown
Contributor

@rahulait rahulait commented Apr 14, 2026

Description

Currently, if version is quoted in values.yaml file, renovate fails to correctly parse it. Ignore quotes around the version so that version can be correctly detected.

Used following command to test the change from gpu-operator dir.

docker run --rm   -v "$PWD:/usr/src/app"   -w /usr/src/app   -e LOG_LEVEL=debug   -e RENOVATE_PLATFORM=local   -e RENOVATE_DRY_RUN=full   renovate/renovate

Sample log before the fix:

               {
                 "depName": "nvcr.io/nvidia/cloud-native/nvidia-sandbox-device-plugin",
                 "currentValue": "\"v0.0.2\"",
                 "datasource": "docker",
                 "versioning": "regex:^v?(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<patch>\\d+)$",
                 "replaceString": "\n  repository: nvcr.io/nvidia/cloud-native\n  image: nvidia-sandbox-device-plugin\n  version: \"v0.0.2\"",
                 "updates": [],
                 "packageName": "nvcr.io/nvidia/cloud-native/nvidia-sandbox-device-plugin",
                 "warnings": [],
                 "skipReason": "invalid-value"
               },

Sample log after the fix:

               {
                 "depName": "nvcr.io/nvidia/cloud-native/nvidia-sandbox-device-plugin",
                 "currentValue": "v0.0.2",
                 "datasource": "docker",
                 "versioning": "regex:^v?(?<major>\\d+)\\.(?<minor>\\d+)\\.(?<patch>\\d+)$",
                 "replaceString": "\n  repository: nvcr.io/nvidia/cloud-native\n  image: nvidia-sandbox-device-plugin\n  version: \"v0.0.2\"",
                 "updates": [
                   {
                     "bucket": "latest",
                     "newVersion": "v0.0.3",
                     "newValue": "v0.0.3",
                     "newMajor": 0,
                     "newMinor": 0,
                     "newPatch": 3,
                     "updateType": "patch",
                     "isBreaking": false,
                     "branchName": "renovate/nvcr.ionvidiacloud-nativenvidia-sandbox-device-plugin"
                   }
                 ],
                 "packageName": "nvcr.io/nvidia/cloud-native/nvidia-sandbox-device-plugin",
                 "warnings": [],
                 "registryUrl": "https://nvcr.io",
                 "homepage": "https://developer.download.nvidia.com/distroless-oss/index.html",
                 "lookupName": "nvidia/cloud-native/nvidia-sandbox-device-plugin",
                 "currentVersion": "v0.0.2",
                 "isSingleVersion": true,
                 "fixedVersion": "v0.0.2"
               },

Checklist

  • No secrets, sensitive information, or unrelated changes
  • Lint checks passing (make lint)
  • Generated assets in-sync (make validate-generated-assets)
  • Go mod artifacts in-sync (make validate-modules)
  • Test cases are added for new code paths

Testing

Signed-off-by: Rahul Sharma <rahulsharm@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant