Conversation
robfitzgerald
approved these changes
Dec 21, 2022
Collaborator
robfitzgerald
left a comment
robfitzgerald
left a comment
There was a problem hiding this comment.
wow, killer 🐝s dude, thanks for catching these.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies a couple of bug fixes discovered when creating a new hive scenario:
charge queue
When transitioning out of dispatch station we were only going into charge queuing if the available chargers result was None. But, there were cases when this evaluated to 0. This has been updated such that the available chargers method only returns an integer and it gets properly checked.
vehicle state updates
I was running into some very strange behavior in which I would observe the vehicle stepping properly in the internal closure of the
perform_vehicle_state_updatesmethod, breaking here but then the change would not be reflected in the result here. I revised the code to use a for loop and moved the_step_vehiclefunction out of the scope of theperform_vehicle_state_updatesand the behavior is gone. This smells like something a bit deep and I didn't have time to investigate further.