Cleanup unused imports, sort other imports#171
Merged
nreinicke merged 4 commits intoNatLabRockies:mainfrom Apr 24, 2023
Merged
Conversation
robfitzgerald
requested changes
Apr 24, 2023
Collaborator
robfitzgerald
left a comment
robfitzgerald
left a comment
There was a problem hiding this comment.
beautiful. 💐 found a straggler from another branch but otherwise great, thanks JetBrains!
| @@ -0,0 +1,15 @@ | |||
| # from nrel.hive.model.sim_time import SimTime | |||
Collaborator
There was a problem hiding this comment.
looks like this change snuck in from another branch?
Contributor
Author
There was a problem hiding this comment.
Yep, let me revert this file
Collaborator
|
@jhoshiko @nreinicke this looks good to me but it's a repo-wide change that will impact pycon sprint participants, so i'll leave it to you to pick the timing for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the bog-standard PyCharm "Optimize Imports" which removes unused imports and also sorts imports to the standard stdlib-thirdparty-local grouping