Conversation
Collaborator
|
looks good! i'd say generally it gives a good impression of what we simulate. a few things if you're up for a revision:
|
Collaborator
Author
|
Good call on the legend, I just pushed up a new image with the legend and a decreased time range to try to get it to be smoother. You might have to wait for the image to be refreshed on GitHub's side (it's still showing the old image for me) |
robfitzgerald
approved these changes
Apr 26, 2023
Collaborator
robfitzgerald
left a comment
There was a problem hiding this comment.
dude, beautiful.
i see there's a bunch of other little changes to the kepler code. i remember seeing that timestamps were getting stringified; i take it that kepler properly interprets them as epoch times only if they are int typed. that and switching to the correct date range in the scenario.yaml is great, so i'm all about this! 🐝
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an animated GIF of the manhattan scenario to the README;
I had a hard time balancing image size and resolution and so I would be curious to hear how the gif looks on your respective browsers.