Skip to content

Ndr/add animated gif#198

Merged
nreinicke merged 6 commits intomainfrom
ndr/add-animated-gif
Apr 26, 2023
Merged

Ndr/add animated gif#198
nreinicke merged 6 commits intomainfrom
ndr/add-animated-gif

Conversation

@nreinicke
Copy link
Copy Markdown
Collaborator

Adds an animated GIF of the manhattan scenario to the README;

I had a hard time balancing image size and resolution and so I would be curious to hear how the gif looks on your respective browsers.

@robfitzgerald
Copy link
Copy Markdown
Collaborator

looks good! i'd say generally it gives a good impression of what we simulate. a few things if you're up for a revision:

  • animations aren't super smooth, maybe because the time range is too long
    • restrict the events to a 1-hour time range, does that help get the time fader to provide smoother interpolation?
  • legend would be nice
    • that's a popup you can click on at the right side of the page
    • then, reposition the animation so it is close to the legend before performing a screen capture

@nreinicke
Copy link
Copy Markdown
Collaborator Author

Good call on the legend, I just pushed up a new image with the legend and a decreased time range to try to get it to be smoother. You might have to wait for the image to be refreshed on GitHub's side (it's still showing the old image for me)

Copy link
Copy Markdown
Collaborator

@robfitzgerald robfitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dude, beautiful.

i see there's a bunch of other little changes to the kepler code. i remember seeing that timestamps were getting stringified; i take it that kepler properly interprets them as epoch times only if they are int typed. that and switching to the correct date range in the scenario.yaml is great, so i'm all about this! 🐝

@nreinicke nreinicke merged commit a699443 into main Apr 26, 2023
@nreinicke nreinicke deleted the ndr/add-animated-gif branch April 26, 2023 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants