[MIG] mrp_product_expiry: Migrate to 18.0#5595
[MIG] mrp_product_expiry: Migrate to 18.0#5595odooerpdevelopers wants to merge 1 commit intoOCA:18.0from
Conversation
odooerpdevelopers
commented
Apr 18, 2026
- No database layout changes between Odoo 17.0 and 18.0
- Module code is identical between versions
- Updated coverage documentation in modules170-180.rst
- Migration scripts follow OCA standards and Ruff formatting
- No database layout changes between Odoo 17.0 and 18.0 - Module code is identical between versions - Updated coverage documentation in modules170-180.rst - Migration scripts follow OCA standards and Ruff formatting
| @openupgrade.migrate() | ||
| def migrate(env, version): | ||
| """No changes needed in data for mrp_product_expiry 17.0 -> 18.0""" | ||
| pass |
| @openupgrade.migrate() | ||
| def migrate(env, version): | ||
| """No changes needed in schema for mrp_product_expiry 17.0 -> 18.0""" | ||
| pass |
| None | ||
|
|
||
| ---Schema changes summary--- | ||
| No database schema changes required. |
| ---Schema changes summary--- | ||
| No database schema changes required. | ||
| # NOTHING TO DO: This is a lightweight technical module with no database changes | ||
| # between versions 17.0 and 18.0. All functionality is preserved as-is. |
remi-filament
left a comment
There was a problem hiding this comment.
Thanks @odooerpdevelopers for your contribution.
In case there is no change like here, you should only update docsource/modules170-180.rst
Other changes are useless and should be removed.
Also PR should be named "[18.0][OU-ADD] mrp_product_expiry: Nothing to do" to be more explicit.
|
Hi all, thanks a lot for your review and guidance. This is my first contribution to OpenUpgrade, so I really appreciate the feedback. I wasn’t fully aware of all the contribution guidelines yet, especially regarding when migration scripts are not needed. I’ll update the PR accordingly and remove the unnecessary files as suggested. I’m very motivated to start contributing more actively to this project, as I find it really interesting. I believe that with the help of modern tools and technologies we can help speed up contributions and add value to the community. If you have any recommendations, best practices, or examples of good PRs to follow, I would really appreciate it. I’m eager to learn and align with the project standards. Thanks again for your patience and support! |