Skip to content

[MIG] mrp_product_expiry: Migrate to 18.0#5595

Open
odooerpdevelopers wants to merge 1 commit intoOCA:18.0from
odooerpdevelopers:18.0-mig-mrp_product_expiry
Open

[MIG] mrp_product_expiry: Migrate to 18.0#5595
odooerpdevelopers wants to merge 1 commit intoOCA:18.0from
odooerpdevelopers:18.0-mig-mrp_product_expiry

Conversation

@odooerpdevelopers
Copy link
Copy Markdown

  • No database layout changes between Odoo 17.0 and 18.0
  • Module code is identical between versions
  • Updated coverage documentation in modules170-180.rst
  • Migration scripts follow OCA standards and Ruff formatting

- No database layout changes between Odoo 17.0 and 18.0
- Module code is identical between versions
- Updated coverage documentation in modules170-180.rst
- Migration scripts follow OCA standards and Ruff formatting
@OCA-git-bot OCA-git-bot added mod:openupgrade_scripts Module openupgrade_scripts series:18.0 labels Apr 18, 2026
@openupgrade.migrate()
def migrate(env, version):
"""No changes needed in data for mrp_product_expiry 17.0 -> 18.0"""
pass
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file in nonsense, remove

@openupgrade.migrate()
def migrate(env, version):
"""No changes needed in schema for mrp_product_expiry 17.0 -> 18.0"""
pass
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

None

---Schema changes summary---
No database schema changes required.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't edit this file

---Schema changes summary---
No database schema changes required.
# NOTHING TO DO: This is a lightweight technical module with no database changes
# between versions 17.0 and 18.0. All functionality is preserved as-is.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove nonsense comments

Copy link
Copy Markdown
Contributor

@remi-filament remi-filament left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @odooerpdevelopers for your contribution.
In case there is no change like here, you should only update docsource/modules170-180.rst
Other changes are useless and should be removed.

Also PR should be named "[18.0][OU-ADD] mrp_product_expiry: Nothing to do" to be more explicit.

@odooerpdevelopers
Copy link
Copy Markdown
Author

Hi all, thanks a lot for your review and guidance.

This is my first contribution to OpenUpgrade, so I really appreciate the feedback. I wasn’t fully aware of all the contribution guidelines yet, especially regarding when migration scripts are not needed. I’ll update the PR accordingly and remove the unnecessary files as suggested.

I’m very motivated to start contributing more actively to this project, as I find it really interesting. I believe that with the help of modern tools and technologies we can help speed up contributions and add value to the community.

If you have any recommendations, best practices, or examples of good PRs to follow, I would really appreciate it. I’m eager to learn and align with the project standards.

Thanks again for your patience and support!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:openupgrade_scripts Module openupgrade_scripts series:18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants