[19.0][IMP] hr: set contract start date to employee's create date#5605
Open
[19.0][IMP] hr: set contract start date to employee's create date#5605
Conversation
OCA-git-bot
added
mod:openupgrade_scripts
pedrobaeza
approved these changes
Apr 27, 2026
Member
pedrobaeza
left a comment
pedrobaeza
left a comment
There was a problem hiding this comment.
I think it's better to not have them deactivated, although the date is not correct. I suppose this date is modified having hr_contract installed, isn't it?
Member
Author
yes. So they aren't deactivated in the active=False sense, but whenever something date dependent happens, https://github.com/odoo/odoo/blob/19.0/addons/hr/models/hr_employee.py#L1622 is called, which excludes employees without start date |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this one is more an rfc: When migrating a database without hr_contract, all employees end up without a contract start date. Any code looking for active versions will treat those employees as inactive, so it might be a good idea to set some date.
On the other hand, this will most likely be a wrong date, so that's an argument for not doing it and having HR managers fill in the correct date afterwards.