[17.0][MIG] web_refresher: Migration to 17.0 by TesaLazarenko · Pull Request #2669 · OCA/web

TesaLazarenko · 2023-11-15T10:46:56Z

No description provided.

TT28809

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/

… views

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/

Currently translated at 100.0% (2 of 2 strings) Translation: web-16.0/web-16.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/hr/

Currently translated at 50.0% (1 of 2 strings) Translation: web-16.0/web-16.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/fr/

legalsylvain · 2023-11-15T11:48:32Z

/ocabot migration web_refresher

pedrobaeza · 2023-11-15T18:57:24Z

Tested on runbot and working.

question: Is there a reason to put the button on the center instead of next to the pager as always?

TesaLazarenko · 2023-11-16T16:44:56Z

Tested on runbot and working.

question: Is there a reason to put the button on the center instead of next to the pager as always?

Hi, there were a few reasons for that, in previous versions, page refresh was not available on all views where it was most often needed, in the current version I attach this in not only pager, which allows you to get this functionality almost everywhere. In the image of odoo 15, as you can see, the update functionality is not available, so placing it in the search component solves this problem

pedrobaeza · 2023-11-16T16:46:12Z

But we worked on that on all the versions:

Original in 13.0: #2243
Forward-port for 15.0: #2365
Forward-port for 16.0: #2366

so if it's not working completely in 16.0, it should be fixed, but putting in the middle seems a bit weird.

TesaLazarenko · 2023-11-16T17:00:37Z

But we worked on that on all the versions:

Original in 13.0: #2243 Forward-port for 15.0: #2365 Forward-port for 16.0: #2366

so if it's not working completely in 16.0, it should be fixed, but putting in the middle seems a bit weird.

If someone else can confirm that this position is strange or inconvenient, I'll move this to the pager as it was before, but I'm not sure that this functionality will be available on reports

TesaLazarenko · 2023-11-16T17:36:12Z

But we worked on that on all the versions:
Original in 13.0: #2243 Forward-port for 15.0: #2365 Forward-port for 16.0: #2366
so if it's not working completely in 16.0, it should be fixed, but putting in the middle seems a bit weird.

If someone else can confirm that this position is strange or inconvenient, I'll move this to the pager as it was before, but I'm not sure that this functionality will be available on reports

now I'm working on the preliminary look, it looks like everything could be fine

TesaLazarenko · 2023-11-16T22:23:26Z

chienandalu · 2023-11-17T10:11:54Z

+
+    async onClickRefresh() {
+        await this.refresh();
+        this.notification.add(_t("Refreshed"), {


No very convinced with this :) Is it really needed?

No very convinced with this :) Is it really needed?

Are you talking about this.notification.add or the entire component?

Yes, just the notification of the refresh :)

this is not necessary, but I noticed in my experience that if you do not display anything, it is not immediately clear whether the click has worked, in a situation where there were no new changes to update

If you think it's unnecessary or distracting, I can remove it

Maybe a shorter notification close timeout would be less anoying

ok, I'll think about a simplified version of the notification, as a last resort I'll just remove it.
I'll deal with it later.

Any other comments on other points?

What about this animation instead of notification (the red ring is added by the screen recorder)

Maybe a shorter notification close timeout would be less anoying

jcdrubay

Test on runboat, it works very nicely. Nice :)

pedrobaeza

/ocabot merge nobump

OCA-git-bot · 2023-11-24T19:37:23Z

This PR looks fantastic, let's merge it!
Prepared branch 17.0-ocabot-merge-pr-2669-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2023-11-24T19:37:43Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

OCA-git-bot · 2023-11-24T19:40:39Z

Congratulations, your PR was merged at 0958651. Thanks a lot for contributing to OCA. ❤️

josueBulle and others added 30 commits November 15, 2023 12:27

[11.0][ADD] web_refresh

1f6a6d0

Fix refactor

1741fd4

readme

f0f566b

updated manifest

26ac646

Added translation using Weblate (Spanish)

8f54925

Added translation using Weblate (Catalan)

2ff9ed6

Added translation using Weblate (Portuguese (Brazil))

4c04863

[IMP] web_refresher: black, isort, prettier

a9192d2

[MIG] web_refresher: Migration to 13.0

9e224b9

TT28809

[IMP] web_refresher: black, isort, prettier

a73c09c

[MIG] web_refresher: Migration to 14.0

b0c45b3

[UPD] Update web_refresher.pot

ec03fd9

[UPD] README.rst

c9c3bb7

[MIG] web_refresher: Migration to 15.0

31dc9ab

[UPD] Update web_refresher.pot

ee3ca8d

[UPD] README.rst

e822a4c

[MIG] web_refresher: Migration to 16.0

0ab3659

[UPD] Update web_refresher.pot

259527b

[UPD] README.rst

fb8f121

Update translation files

6cc2ce6

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/

[UPD] Update web_refresher.pot

3eb839c

Update translation files

fd80ab1

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/

[IMP] web_refresher: Work as component of control panel

0e17634

[IMP] web_refresher: Add component to pager to avoid instance for all…

8a68bec

… views

[UPD] Update web_refresher.pot

f7af744

[UPD] README.rst

c6e3201

web_refresher 16.0.2.0.0

5125743

Update translation files

9d32367

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: web-16.0/web-16.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/

Added translation using Weblate (Croatian)

3559db6

Translated using Weblate (Croatian)

8629983

Currently translated at 100.0% (2 of 2 strings) Translation: web-16.0/web-16.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/hr/

Translated using Weblate (French)

248cf47

Currently translated at 50.0% (1 of 2 strings) Translation: web-16.0/web-16.0-web_refresher Translate-URL: https://translation.odoo-community.org/projects/web-16-0/web-16-0-web_refresher/fr/

OCA-git-bot added this to the 17.0 milestone Nov 15, 2023

OCA-git-bot mentioned this pull request Nov 15, 2023

Migration to version 17.0 #2661

Open

33 tasks

TesaLazarenko closed this Nov 16, 2023

TesaLazarenko reopened this Nov 16, 2023

TesaLazarenko force-pushed the 17.0-mig-web_refresher branch from 0a1c79f to 68c5beb Compare November 16, 2023 22:20

chienandalu reviewed Nov 17, 2023

View reviewed changes

TesaLazarenko force-pushed the 17.0-mig-web_refresher branch from 68c5beb to 8ec3058 Compare November 17, 2023 12:26

[MIG] web_refresher: Migration to 17.0

21765c4

TesaLazarenko force-pushed the 17.0-mig-web_refresher branch from 8ec3058 to 21765c4 Compare November 17, 2023 12:27

jcdrubay approved these changes Nov 20, 2023

View reviewed changes

pedrobaeza changed the title ~~[MIG] web_refresher: Migration to 17.0~~ [17.0][MIG] web_refresher: Migration to 17.0 Nov 24, 2023

pedrobaeza approved these changes Nov 24, 2023

View reviewed changes

OCA-git-bot added the approved label Nov 24, 2023

OCA-git-bot added bot is merging ⏳ ready to merge labels Nov 24, 2023

OCA-git-bot merged commit 84ab4d7 into OCA:17.0 Nov 24, 2023

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Nov 24, 2023

amarcosg mentioned this pull request Jul 18, 2024

[16.0] web_refresher: Refresh action returns to create a new record when already has been created the record #2836

Closed

Uh oh!

Conversation

TesaLazarenko commented Nov 15, 2023

Uh oh!

legalsylvain commented Nov 15, 2023

Uh oh!

pedrobaeza commented Nov 15, 2023

Uh oh!

TesaLazarenko commented Nov 16, 2023

Uh oh!

pedrobaeza commented Nov 16, 2023

Uh oh!

TesaLazarenko commented Nov 16, 2023

Uh oh!

TesaLazarenko commented Nov 16, 2023

Uh oh!

TesaLazarenko commented Nov 16, 2023

Uh oh!

chienandalu Nov 17, 2023

Choose a reason for hiding this comment

Uh oh!

TesaLazarenko Nov 17, 2023

Choose a reason for hiding this comment

Uh oh!

chienandalu Nov 17, 2023

Choose a reason for hiding this comment

Uh oh!

TesaLazarenko Nov 17, 2023

Choose a reason for hiding this comment

Uh oh!

TesaLazarenko Nov 17, 2023

Choose a reason for hiding this comment

Uh oh!

chienandalu Nov 17, 2023

Choose a reason for hiding this comment

Uh oh!

TesaLazarenko Nov 17, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

TesaLazarenko Nov 17, 2023

Choose a reason for hiding this comment

Uh oh!

jcdrubay left a comment

Choose a reason for hiding this comment

Uh oh!

pedrobaeza left a comment

Choose a reason for hiding this comment

Uh oh!

OCA-git-bot commented Nov 24, 2023

Uh oh!

OCA-git-bot commented Nov 24, 2023

Uh oh!

OCA-git-bot commented Nov 24, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

TesaLazarenko Nov 17, 2023 •

edited

Loading